Last Comment Bug 759643 - Properly always create a DXGI 1.1 device
: Properly always create a DXGI 1.1 device
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: unspecified
: x86_64 Windows 7
: -- normal (vote)
: mozilla15
Assigned To: Bas Schouten (:bas.schouten)
:
Mentors:
Depends on:
Blocks: 734404
  Show dependency treegraph
 
Reported: 2012-05-29 21:48 PDT by Bas Schouten (:bas.schouten)
Modified: 2012-05-30 07:34 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Only check for D3D 10.0 support when selecting a DXGI 1.1 adapter (1011 bytes, patch)
2012-05-29 21:48 PDT, Bas Schouten (:bas.schouten)
no flags Details | Diff | Review
Only check for D3D 10.0 support when selecting a DXGI 1.1 adapter v2 (1.34 KB, patch)
2012-05-29 21:51 PDT, Bas Schouten (:bas.schouten)
roc: review+
Details | Diff | Review

Description Bas Schouten (:bas.schouten) 2012-05-29 21:48:15 PDT
Created attachment 628213 [details] [diff] [review]
Only check for D3D 10.0 support when selecting a DXGI 1.1 adapter

In order to properly create textures that can do synchronization we need a DXGI 1.1 adapter to be used for device creation. This can be done on all updated Windows 7 and Vista, and we currently try this. However if the device does not support D3D 10.1 we wrongly toss out the adapter and create the device with a NULL adapter. This is wrong and prevents DXGI async drawing from working on DX10 machines.
Comment 1 Bas Schouten (:bas.schouten) 2012-05-29 21:51:58 PDT
Created attachment 628214 [details] [diff] [review]
Only check for D3D 10.0 support when selecting a DXGI 1.1 adapter v2

Updated: It's probably a better idea to fail D2D acceleration all together if this weird situation should occur where we can somehow get a D3D10.0 device without DXGI 1.1 support.
Comment 2 Bas Schouten (:bas.schouten) 2012-05-29 21:58:14 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/3187b6d743db
Comment 3 Ed Morley [:emorley] 2012-05-30 07:34:01 PDT
Please can you set the milestone when landing. Thanks :-)

https://hg.mozilla.org/mozilla-central/rev/3187b6d743db

Note You need to log in before you can comment on or make changes to this bug.