759655 - pressing return to select a component from the product/component search doesn't work

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: User Interface, defect)

Description

[:glob ✱]

pressing return to select a component from the product/component search doesn't work, it just closes the auto-complete menu.  you have to click on an item with the mouse.

Comment 1

[David Lawrence [:dkl]]

Attachment: Patch to allow hitting enter on an item in product autocomplete (v1)

This works well for me. I am going to test in IE to make sure it works but submitting for review now.

dkl

Comment 2

[David Lawrence [:dkl]]

Should mention that this patch also works in GuidedBugEntry.

Comment 3

[David Lawrence [:dkl]]

Just verified that this works in IE9 in both places.

Comment 4

[:glob ✱]

Comment on attachment 628488 [details] [diff] [review]
Patch to allow hitting enter on an item in product autocomplete (v1)

Review of attachment 628488 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob,
please fix the delimiter change on commit.

::: extensions/BMO/web/js/choose_product.js
@@ +25,4 @@
>        return YAHOO.lang.JSON.stringify(json_object);
>      },
>      resultListFormat : function(oResultData, enteredText, sResultMatch) {
> +        return _escapeHTML(oResultData[0]) + " / " + _escapeHTML(oResultData[1]);

please change the delimiter from " / " back to " :: ".
there are components which include /, which results in a confusing display:
eg. Mozilla Localizations / cy / Welsh

Comment 5

[Reed Loden [:reed]]

Comment on attachment 628488 [details] [diff] [review]
Patch to allow hitting enter on an item in product autocomplete (v1)

On bmo 4.2, extensions/BMO/web/js/choose_product.js needs to be changed to use YAHOO.lang.escapeHTML() instead of _escapeHTML(), as the latter does not exist there.

Comment 6

[Reed Loden [:reed]]

Actually, I think bmo 4.0 branch is using a new enough YUI that you could just move completely to YAHOO.lang.escapeHTML() everywhere.

Comment 7

[:glob ✱]

(In reply to Reed Loden [:reed] from comment #6)
> Actually, I think bmo 4.0 branch is using a new enough YUI that you could
> just move completely to YAHOO.lang.escapeHTML() everywhere.

agreed; looks like extensions/BMO/web/js/choose_product.js is the only place that uses _escapeHTML

Comment 8

[David Lawrence [:dkl]]

(In reply to Reed Loden [:reed] from comment #5)
> On bmo 4.2, extensions/BMO/web/js/choose_product.js needs to be changed to
> use YAHOO.lang.escapeHTML() instead of _escapeHTML(), as the latter does not
> exist there.

Done. Thanks.

(In reply to Byron Jones ‹:glob› from comment #4)
> please change the delimiter from " / " back to " :: ".
> there are components which include /, which results in a confusing display:
> eg. Mozilla Localizations / cy / Welsh

Also changed this. Both will show up in the final commit.

dkl

Comment 9

[David Lawrence [:dkl]]

Committing to: bzr+ssh://[e-mail]/bmo/4.0
modified extensions/BMO/web/js/choose_product.js
Committed revision 8204.

Committing to: bzr+ssh://[e-mail]/bmo/4.2
modified extensions/BMO/web/js/choose_product.js
Committed revision 8182.