759656 - Some PopupNotification consumers expect a notification argument to the mainAction callback

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Matthew N. [:MattN]]

Attachment: v.1 Remove unused/unimplemented callback argument

PopupNotifications.jsm does:

notification.mainAction.callback.call();
  and 
target.action.callback.call();

with no arguments to the action callbacks but some consumers are expecting an argument.

This patch just removes the unused argument from the two consumers.

Comment 1

[:Margaret Leibovic]

Comment on attachment 628234 [details] [diff] [review]
v.1 Remove unused/unimplemented callback argument

Good spot. These probably crept in there because the notification bar API does take a parameter.

Comment 2

[Matthew N. [:MattN]]

https://hg.mozilla.org/integration/fx-team/rev/3532b3c14ae5

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/3532b3c14ae5