The default bug view has changed. See this FAQ.

Some PopupNotification consumers expect a notification argument to the mainAction callback

RESOLVED FIXED in Firefox 16

Status

()

Firefox
General
--
trivial
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: MattN, Assigned: MattN)

Tracking

Trunk
Firefox 16
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 628234 [details] [diff] [review]
v.1 Remove unused/unimplemented callback argument

PopupNotifications.jsm does:

notification.mainAction.callback.call();
  and 
target.action.callback.call();

with no arguments to the action callbacks but some consumers are expecting an argument.

This patch just removes the unused argument from the two consumers.
Attachment #628234 - Flags: review?(margaret.leibovic)

Comment 1

5 years ago
Comment on attachment 628234 [details] [diff] [review]
v.1 Remove unused/unimplemented callback argument

Good spot. These probably crept in there because the notification bar API does take a parameter.
Attachment #628234 - Flags: review?(margaret.leibovic) → review+
https://hg.mozilla.org/integration/fx-team/rev/3532b3c14ae5
Flags: in-testsuite-
Target Milestone: --- → Firefox 16
https://hg.mozilla.org/mozilla-central/rev/3532b3c14ae5
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.