759770 - Fix build error when warnings-as-errors in nsSVGUtils.cpp

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Mounir Lamouri (:mounir)]

Patch coming (as soon as the build will succeed).

Comment 1

[Mounir Lamouri (:mounir)]

Attachment: Patch

Comment 2

[Daniel Holbert [:dholbert]]

Comment on attachment 628348 [details] [diff] [review]
Patch

Explicitly ignoring the return value from fwrite is probably bad in general, since we might want to check it for failure, but it's not worth it in this instance since this is debug-only logging code.

So, r=me -- thanks!

Comment 3

[Daniel Holbert [:dholbert]]

Actually, it looks like this entire function is unused.  Maybe we should just delete it.
http://mxr.mozilla.org/mozilla-central/search?string=writeppm

Comment 4

[Daniel Holbert [:dholbert]]

Mm, per bug 389498 comment 13, it sounds like this function is intentionally unused & might be handy for debugging from time to time.

Let's just land the patch as-is.

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/9bddce44625c

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

(In reply to Ed Morley [:edmorley] from comment #5)
> https://hg.mozilla.org/mozilla-central/rev/9bddce44625c

Empty patch

Comment 7

[Mounir Lamouri (:mounir)]

I don't know what happened... I've very likely imported the wrong patch in my m-i repo.
Anyhow:
https://hg.mozilla.org/mozilla-central/rev/cb648ec7d7f2

Thank you for noticing that Ms2ger ;)