Closed Bug 759770 Opened 9 years ago Closed 9 years ago

Fix build error when warnings-as-errors in nsSVGUtils.cpp

Categories

(Core :: SVG, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla15

People

(Reporter: mounir, Assigned: mounir)

References

Details

Attachments

(1 file)

Patch coming (as soon as the build will succeed).
Attached patch PatchSplinter Review
Attachment #628348 - Flags: review?(dholbert)
Comment on attachment 628348 [details] [diff] [review]
Patch

Explicitly ignoring the return value from fwrite is probably bad in general, since we might want to check it for failure, but it's not worth it in this instance since this is debug-only logging code.

So, r=me -- thanks!
Attachment #628348 - Flags: review?(dholbert) → review+
Actually, it looks like this entire function is unused.  Maybe we should just delete it.
http://mxr.mozilla.org/mozilla-central/search?string=writeppm
Mm, per bug 389498 comment 13, it sounds like this function is intentionally unused & might be handy for debugging from time to time.

Let's just land the patch as-is.
Blocks: 389498
Attachment #628348 - Flags: checkin+
Flags: in-testsuite-
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/9bddce44625c
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
(In reply to Ed Morley [:edmorley] from comment #5)
> https://hg.mozilla.org/mozilla-central/rev/9bddce44625c

Empty patch
I don't know what happened... I've very likely imported the wrong patch in my m-i repo.
Anyhow:
https://hg.mozilla.org/mozilla-central/rev/cb648ec7d7f2

Thank you for noticing that Ms2ger ;)
You need to log in before you can comment on or make changes to this bug.