[b2g-bluetooth] Divide out bluetooth specifics from DBusThread object

RESOLVED FIXED in mozilla17

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: qdot, Assigned: qdot)

Tracking

Trunk
mozilla17
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Now that we are dividing out DBus specific functionality into a BluetoothDBusUtils file, move DBus specific functions for bluetooth event filtering to this file also.
Summary: Divide out bluetooth specifics from DBusThread object → [b2g-bluetooth] Divide out bluetooth specifics from DBusThread object
No longer blocks: 727618
Nice to have if anyone else ever wanted to use the dbus core we've implemented, but not a blocker on b2g-bluetooth or kilimanjaro
Created attachment 649852 [details] [diff] [review]
Patch 1: Move dbus event registration to bluetooth dbus specific code
Attachment #649852 - Flags: review?(echou)
Comment on attachment 649852 [details] [diff] [review]
Patch 1: Move dbus event registration to bluetooth dbus specific code

Looks good to me. 

I noticed that DBUS_SIGNALS will not be used at any other place if this patch is applied. Please check if it's o.k to remove it.
Attachment #649852 - Flags: review?(echou) → review+
DBUS_SIGNALS nit picked.

https://hg.mozilla.org/integration/mozilla-inbound/rev/9215610e05a1
Target Milestone: --- → mozilla17

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/9215610e05a1
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.