Closed
Bug 759883
Opened 12 years ago
Closed 12 years ago
[b2g-bluetooth] Divide out bluetooth specifics from DBusThread object
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: qdot, Assigned: qdot)
Details
Attachments
(1 file)
|
4.61 KB,
patch
|
echou
:
review+
|
Details | Diff | Splinter Review |
Now that we are dividing out DBus specific functionality into a BluetoothDBusUtils file, move DBus specific functions for bluetooth event filtering to this file also.
|
Assignee | |
Updated•12 years ago
|
Summary: Divide out bluetooth specifics from DBusThread object → [b2g-bluetooth] Divide out bluetooth specifics from DBusThread object
|
|
Assignee | |
Updated•12 years ago
|
No longer blocks: b2g-bluetooth
|
|
Assignee | |
Comment 1•12 years ago
|
||
Nice to have if anyone else ever wanted to use the dbus core we've implemented, but not a blocker on b2g-bluetooth or kilimanjaro
|
|
Assignee | |
Comment 2•12 years ago
|
||
Attachment #649852 -
Flags: review?(echou)
|
||
Comment 3•12 years ago
|
||
Comment on attachment 649852 [details] [diff] [review] Patch 1: Move dbus event registration to bluetooth dbus specific code Looks good to me. I noticed that DBUS_SIGNALS will not be used at any other place if this patch is applied. Please check if it's o.k to remove it.
Attachment #649852 -
Flags: review?(echou) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
DBUS_SIGNALS nit picked. https://hg.mozilla.org/integration/mozilla-inbound/rev/9215610e05a1
|
|
Assignee | |
Updated•12 years ago
|
Target Milestone: --- → mozilla17
|
||
Comment 5•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9215610e05a1
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•