Closed Bug 759997 Opened 13 years ago Closed 13 years ago

Factor out the three arms of SurfaceFromElement into separate functions

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla15

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(1 file)

Break out the three branches of SurfaceFromElement into separate functions so that we can call the one that matches the kind of element we have directly.
12.87 KB, patch
roc
: review+
Details | Diff | Splinter Review
With the new DOM bindings and overload resolution, we actually know coming in what sort of element we have, so there's no need to redetect it.
Depends on: 748266
https://hg.mozilla.org/integration/mozilla-inbound/rev/6a46906eb017
Flags: in-testsuite-
Whiteboard: [need review]
Target Milestone: --- → mozilla15
Backed out because I had to back out bug 748266.
Whiteboard: [need bug 748266 relanded]
Target Milestone: mozilla15 → ---
And relanded: https://hg.mozilla.org/integration/mozilla-inbound/rev/aeca3790f053
Whiteboard: [need bug 748266 relanded]
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/aeca3790f053
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: