Closed Bug 760002 Opened 12 years ago Closed 12 years ago

A lot of warnings if Aero Window Title is enabled on debug build: "WARNING: Multiple glass backgrounds found?: file m:\mc-a\src\layout\base\nsDisplayList.h, line 481"

Categories

(Core :: Layout, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: masayuki, Unassigned)

References

Details

Attachments

(1 file)

If I enable Aero Window Title (https://addons.mozilla.org/en-US/firefox/addon/aero-window-title/?src=api) on debug build, there are a lot of same warnings are printed. That is:

"WARNING: Multiple glass backgrounds found?: file m:\mc-a\src\layout\base\nsDisplayList.h, line 481"

I'm not sure if layout has a bug or the addon has a bug. However, it seems that there is a situation which are not assumed by the layout code.
The warning was added by bug 749075's part.1 patch.
Blocks: 749075
That addon sets -moz-win-borderlessglass on the stack containing the window title. I'm not sure why that's needed. Benjamin?
I'm... not sure. I kept adding styles until it was the proper glass appearance. I could try removing some styles and see if it still works correctly.
roc:

Anyway, why the warning is necessary? If it's necessary for debugging, using PR_LOG() or something to be enabled by additional condition like prefs might be better.
It doesn't make sense to use -moz-win-borderlessglass on a non-root element. I think the warning is useful since it found what is probably a bug in the addon :-).
Removing both instances of -moz-win-borderlessglass (on aero-titlebar-stack, and on aero-titlebar-highlight) seems to work fine for me.
bsmedberg: ping
what?
(In reply to Benjamin Smedberg  [:bsmedberg] from comment #8)
> what?

So, why don't you fix this on the add-on? According to the roc's comment, the warnings indicate there is a bug in the Aero Window Title.
If you have a patch which works I can commit it to http://hg.mozilla.org/users/bsmedberg_mozilla.com/aero-window-title/ although if it's not hurting anything I probably won't do a release just for this.
Attached patch patch to addonSplinter Review
Benjamin: Here's a patch which should work.
http://hg.mozilla.org/users/bsmedberg_mozilla.com/aero-window-title/rev/36f58ed61858
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: