Closed
Bug 760047
Opened 13 years ago
Closed 13 years ago
Don't handle a null aDocument in nsGlobalWindow::SetNewDocument
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: Ms2ger, Assigned: Ms2ger)
Details
Attachments
(1 file)
|
3.57 KB,
patch
|
mounir
:
review+
|
Details | Diff | Splinter Review |
All the callers null-check the document they pass, so we might as well just assert that it isn't null.
Attachment #628665 -
Flags: review?(bzbarsky)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 628665 [details] [diff] [review]
Patch v1
Review of attachment 628665 [details] [diff] [review]:
-----------------------------------------------------------------
I guess nsGlobalModalWindow::SetNewDocument() can't get a |null| aDocument too, right? Could you add a check there and also remove the condition for |mReturnValue = nsnull;|.
r=me with that.
Attachment #628665 -
Flags: review?(bzbarsky) → review+
|
Assignee | |
Comment 2•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•