The default bug view has changed. See this FAQ.

Don't handle a null aDocument in nsGlobalWindow::SetNewDocument

RESOLVED FIXED in mozilla16

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
mozilla16
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 628665 [details] [diff] [review]
Patch v1

All the callers null-check the document they pass, so we might as well just assert that it isn't null.
Attachment #628665 - Flags: review?(bzbarsky)
Comment on attachment 628665 [details] [diff] [review]
Patch v1

Review of attachment 628665 [details] [diff] [review]:
-----------------------------------------------------------------

I guess nsGlobalModalWindow::SetNewDocument() can't get a |null| aDocument too, right? Could you add a check there and also remove the condition for |mReturnValue = nsnull;|.

r=me with that.
Attachment #628665 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/mozilla-central/rev/fbcca1b454a2
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.