Closed
Bug 760049
Opened 13 years ago
Closed 13 years ago
Move nsIScriptContext::CreateNativeGlobalForInner to nsGlobalWindow.cpp
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: Ms2ger, Assigned: Ms2ger)
Details
Attachments
(1 file)
|
8.81 KB,
patch
|
jst
:
review+
|
Details | Diff | Splinter Review |
nsGlobalWindow::SetNewDocument is the only caller, so I think it's clearer to just put move it there.
Attachment #628669 -
Flags: review?(jst)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 628669 [details] [diff] [review]
Patch v1
- In dom/base/nsIScriptContext.h:
- virtual nsresult CreateNativeGlobalForInner(
- nsIScriptGlobalObject *aNewInner,
- nsIURI *aURI,
...
This changes the vtable layout, which means you need to bump the IID here. And to be on the safe side I'd bump the IID on nsIScriptGlobalObject as well, as I believe that's on the the most common path for getting your hands on an nsIScriptContext, and it's rare for code to QI anything to an nsIScriptContext so bumping the IID in this interface only buys us so much.
Attachment #628669 -
Flags: review?(jst) → review+
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → Ms2ger
|
|
Assignee | |
Comment 2•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•