Move nsIScriptContext::CreateNativeGlobalForInner to nsGlobalWindow.cpp

RESOLVED FIXED in mozilla16

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
mozilla16
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 628669 [details] [diff] [review]
Patch v1

nsGlobalWindow::SetNewDocument is the only caller, so I think it's clearer to just put move it there.
Attachment #628669 - Flags: review?(jst)
Comment on attachment 628669 [details] [diff] [review]
Patch v1

- In dom/base/nsIScriptContext.h:

-  virtual nsresult CreateNativeGlobalForInner(
-                                      nsIScriptGlobalObject *aNewInner,
-                                      nsIURI *aURI,
...

This changes the vtable layout, which means you need to bump the IID here. And to be on the safe side I'd bump the IID on nsIScriptGlobalObject as well, as I believe that's on the the most common path for getting your hands on an nsIScriptContext, and it's rare for code to QI anything to an nsIScriptContext so bumping the IID in this interface only buys us so much.
Attachment #628669 - Flags: review?(jst) → review+
(Assignee)

Updated

5 years ago
Assignee: nobody → Ms2ger
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/mozilla-central/rev/a7a981294c42
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.