Wrapper construct users Wrapper::GET rather than Wrapper::CALL

RESOLVED FIXED in mozilla15

Status

()

Core
XPConnect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bholley, Assigned: bholley)

Tracking

unspecified
mozilla15
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

This makes no sense to me. It also means that COW-ed objects can be ()-ed but not new-ed.

This was the source of some nastiness over in bug 756173. I'll write up a patch right now.
Created attachment 628705 [details] [diff] [review]
Make |construct| use Wrapper::CALL. v1

Attaching a patch. Pushed to try here: https://tbpl.mozilla.org/?tree=Try&rev=4f003eaf3822

Flagging jorendorff for review in case he remembers some reason why it was supposed to be like this.
Attachment #628705 - Flags: review?(jorendorff)
Comment on attachment 628705 [details] [diff] [review]
Make |construct| use Wrapper::CALL. v1

Stealing the review here as this was my fault... It looks like when I added the CALL permission during the brain transplant scramble, I simply forgot to update construct to match call.
Attachment #628705 - Flags: review?(jorendorff) → review+
Looks green. Pushed to try:
http://hg.mozilla.org/integration/mozilla-inbound/rev/d3d7c919fb50
Target Milestone: --- → mozilla15

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/d3d7c919fb50
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.