760076 - Wrapper construct users Wrapper::GET rather than Wrapper::CALL

Status: RESOLVED FIXED

Description

[Bobby Holley (:bholley) (busy with Stylo)]

This makes no sense to me. It also means that COW-ed objects can be ()-ed but not new-ed.

This was the source of some nastiness over in bug 756173. I'll write up a patch right now.

Comment 1

[Bobby Holley (:bholley) (busy with Stylo)]

Created attachment 628705 [details] [diff] [review]
Make |construct| use Wrapper::CALL. v1

Attaching a patch. Pushed to try here: https://tbpl.mozilla.org/?tree=Try&rev=4f003eaf3822

Flagging jorendorff for review in case he remembers some reason why it was supposed to be like this.

Comment 2

[Blake Kaplan (:mrbkap)]

Comment on attachment 628705 [details] [diff] [review]
Make |construct| use Wrapper::CALL. v1

Stealing the review here as this was my fault... It looks like when I added the CALL permission during the brain transplant scramble, I simply forgot to update construct to match call.

Comment 3

[Bobby Holley (:bholley) (busy with Stylo)]

Looks green. Pushed to try:
http://hg.mozilla.org/integration/mozilla-inbound/rev/d3d7c919fb50

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d3d7c919fb50