Wrapper construct users Wrapper::GET rather than Wrapper::CALL
RESOLVED
FIXED
in mozilla15
Status
()
People
(Reporter: bholley, Assigned: bholley)
Tracking
Firefox Tracking Flags
(Not tracked)
Details
Attachments
(1 attachment)
|
3.55 KB,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
This makes no sense to me. It also means that COW-ed objects can be ()-ed but not new-ed. This was the source of some nastiness over in bug 756173. I'll write up a patch right now.
|
(Assignee) | |
Comment 1•7 years ago
|
||
Created attachment 628705 [details] [diff] [review] Make |construct| use Wrapper::CALL. v1 Attaching a patch. Pushed to try here: https://tbpl.mozilla.org/?tree=Try&rev=4f003eaf3822 Flagging jorendorff for review in case he remembers some reason why it was supposed to be like this.
Attachment #628705 -
Flags: review?(jorendorff)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 628705 [details] [diff] [review] Make |construct| use Wrapper::CALL. v1 Stealing the review here as this was my fault... It looks like when I added the CALL permission during the brain transplant scramble, I simply forgot to update construct to match call.
Attachment #628705 -
Flags: review?(jorendorff) → review+
|
|
(Assignee) | |
Comment 3•7 years ago
|
||
Looks green. Pushed to try: http://hg.mozilla.org/integration/mozilla-inbound/rev/d3d7c919fb50
Target Milestone: --- → mozilla15
|
||
Comment 4•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d3d7c919fb50
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•