760085 - White cursor in text entry field within Find in Page

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Attachment: Inbound (05/31) - Galaxy Nexus (Android 4.0.4)

See screenshot.

Comment 1

[Aaron Train [:aaronmt]]

Sounds like all that might be needed here is setting android:textCursorDrawable to @null on the <EditText>, and then setting android:textColor as the cursor colour

Comment 2

[:Margaret Leibovic]

Attachment: patch

That worked. We need to get Aaron writing patches!

Comment 3

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 637995 [details] [diff] [review]
patch

Review of attachment 637995 [details] [diff] [review]:
-----------------------------------------------------------------

http://developer.android.com/sdk/api_diff/12/changes/android.R.attr.html <-- This scares me a bit.
Please test it on a gingerbread device, and if this attribute doesn't give any trouble, this patch is fine with me.
r+ with that check.

Comment 4

[:Margaret Leibovic]

(In reply to Sriram Ramasubramanian [:sriram] from comment #3)
> Comment on attachment 637995 [details] [diff] [review]
> patch
> 
> Review of attachment 637995 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> http://developer.android.com/sdk/api_diff/12/changes/android.R.attr.html <--
> This scares me a bit.
> Please test it on a gingerbread device, and if this attribute doesn't give
> any trouble, this patch is fine with me.
> r+ with that check.

Tested on Gingerbread, and it works fine :)

This bug only exists on ICS, so we don't need to worry about the change actually doing something on older versions, we just need to make sure it doesn't cause problems.

Comment 5

[Sriram Ramasubramanian [:sriram]]

Right, it would be there only on ICS.
I was worried that Android would crash on seeing an "unknown" attribute, which it does at times.

Comment 6

[:Margaret Leibovic]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1be6ac53a907

Comment 7

[:Margaret Leibovic]

Comment on attachment 637995 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): follow-up to find in page (bug 695172)
User impact if declined: cursor isn't visible on ICS
Testing completed (on m-c, etc.): just landed on inbound
Risk to taking this patch (and alternatives if risky): low-risk style change
String or UUID changes made by this patch: n/a

Comment 8

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/1be6ac53a907

Comment 9

[Alex Keybl [:akeybl]]

Comment on attachment 637995 [details] [diff] [review]
patch

[Triage Comment]
Low risk style follow-up for a newly uplifted FN15 feature.

Comment 10

[:Margaret Leibovic]

https://hg.mozilla.org/releases/mozilla-aurora/rev/31663860e616