content/chrome/dom/plugins/test/test_clear_site_data.html ran additional tests after finish() was called

RESOLVED FIXED in mozilla16

Status

()

Core
DOM
--
minor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mats, Assigned: mats)

Tracking

Trunk
mozilla16
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Fallout from the diagnostic patch in bug 677964.
(Assignee)

Comment 1

5 years ago
Created attachment 628708 [details] [diff] [review]
Move the SimpleTest.finish() after the final test is done.
Attachment #628708 - Flags: review?(philringnalda)
Comment on attachment 628708 [details] [diff] [review]
Move the SimpleTest.finish() after the final test is done.

I'm not sure who the right reviewer is, but since this is the first time I've ever seen PluginUtils, I'm pretty sure it's not me.
Attachment #628708 - Flags: review?(philringnalda) → review?(joshmoz)
(Assignee)

Comment 3

5 years ago
https://tbpl.mozilla.org/?usebuildbot=1&tree=Try&rev=5db9663b5473

Comment 4

5 years ago
Which exact test (line #) was running after finish, and what were the conditions? I don't understand why this helps.
(Assignee)

Comment 5

5 years ago
It's the ok() test on line 22:
  ok(PluginUtils.withTestPlugin(runTest), "Test plugin found");

SimpleTest.finish() currently runs inside the 'runTest' callback
so the final ok() runs after it.
(Assignee)

Comment 6

5 years ago
correction: line 23.

Updated

5 years ago
Attachment #628708 - Flags: review?(joshmoz) → review+
(Assignee)

Comment 7

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/e551cdc8a8b1
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/e551cdc8a8b1
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.