Closed
Bug 760088
Opened 13 years ago
Closed 13 years ago
content/chrome/dom/plugins/test/test_clear_site_data.html ran additional tests after finish() was called
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)
Details
Attachments
(1 file)
|
1.58 KB,
patch
|
jaas
:
review+
|
Details | Diff | Splinter Review |
Fallout from the diagnostic patch in bug 677964.
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #628708 -
Flags: review?(philringnalda)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 628708 [details] [diff] [review]
Move the SimpleTest.finish() after the final test is done.
I'm not sure who the right reviewer is, but since this is the first time I've ever seen PluginUtils, I'm pretty sure it's not me.
Attachment #628708 -
Flags: review?(philringnalda) → review?(joshmoz)
|
|
Assignee | |
Comment 3•13 years ago
|
||
Which exact test (line #) was running after finish, and what were the conditions? I don't understand why this helps.
|
|
Assignee | |
Comment 5•13 years ago
|
||
It's the ok() test on line 22:
ok(PluginUtils.withTestPlugin(runTest), "Test plugin found");
SimpleTest.finish() currently runs inside the 'runTest' callback
so the final ok() runs after it.
|
|
Assignee | |
Comment 6•13 years ago
|
||
correction: line 23.
Attachment #628708 -
Flags: review?(joshmoz) → review+
|
|
Assignee | |
Comment 7•13 years ago
|
||
Target Milestone: --- → mozilla16
|
||
Comment 8•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•