Ignore .egg-info directories in source tree

RESOLVED FIXED in mozilla15

Status

defect
RESOLVED FIXED
7 years ago
a year ago

People

(Reporter: kats, Assigned: kats)

Tracking

Trunk
mozilla15
x86_64
macOS
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Posted patch gitignore update (obsolete) — Splinter Review
See bug 758823 for more discussion on where these are coming from and why they can't be gotten rid of easily.
Attachment #628709 - Flags: review?(ehsan)
Please update the .hgignore as well.
Attachment #628709 - Attachment is obsolete: true
Attachment #628709 - Flags: review?(ehsan)
Attachment #628737 - Flags: review?(justin.lebar+bug)
Comment on attachment 628737 [details] [diff] [review]
gitignore and hgignore update

These patterns wfm, but I still want ted to r+ the idea of hg/git-ignoring these files.
Attachment #628737 - Flags: review?(ted.mielczarek)
Attachment #628737 - Flags: review?(justin.lebar+bug)
Attachment #628737 - Flags: feedback+

Comment 4

7 years ago
Kats, is there any particular reason why you asked for me review on this?  I know next to nothing about these directories.  (OK, fine, I don't know anything at all about them!)
(In reply to Ehsan Akhgari [:ehsan] from comment #4)
> Kats, is there any particular reason why you asked for me review on this? 

No, just that you were the last person to touch .gitignore so I figured you would be ok reviewing such a change.
Comment on attachment 628737 [details] [diff] [review]
gitignore and hgignore update

Review of attachment 628737 [details] [diff] [review]:
-----------------------------------------------------------------

Since there's no way to stop producing them without breaking the way I want things to work, we might as well ignore them.
Attachment #628737 - Flags: review?(ted.mielczarek) → review+
https://hg.mozilla.org/mozilla-central/rev/cef3bda40d40
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED

Updated

a year ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.