760238 - Find in page has broken viewport save/restore code

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

The code in browser.js that saves the viewport and restores it when the find-in-page operation is terminated is broken; it uses .viewport instead of getViewport() and setViewport(). As seen in logcat:

05-31 19:27:06.490 E/GeckoConsole(15891): [JavaScript Warning: "ReferenceError: reference to undefined property this._targetTab.viewport" {file: "chrome://browser/content/browser.js" line: 3224}]

Comment 1

[:Margaret Leibovic]

Attachment: patch

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 628978 [details] [diff] [review]
patch

Review of attachment 628978 [details] [diff] [review]:
-----------------------------------------------------------------

The viewport you're restoring won't have a displayport. You should update setViewport() so that the last line of code in it is guarded by a "if (aViewport.displayPort)", or you'll get an error in the log and probably displayport update fail.

Comment 3

[:Margaret Leibovic]

Attachment: update patch

Like so?

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 629234 [details] [diff] [review]
update patch

Review of attachment 629234 [details] [diff] [review]:
-----------------------------------------------------------------

Yup. I assume you exercised the code and checked for any other javascript errors in the logcat (if not, you should do that just to make sure there's nothing else...).

Comment 5

[:Margaret Leibovic]

(In reply to Kartikaya Gupta (:kats) from comment #4)

> Yup. I assume you exercised the code and checked for any other javascript
> errors in the logcat (if not, you should do that just to make sure there's
> nothing else...).

Yes, I did a better job testing now, and verified it does all work without errors :)

Comment 6

[:Margaret Leibovic]

https://hg.mozilla.org/integration/mozilla-inbound/rev/758bde132601

Comment 7

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/758bde132601