Last Comment Bug 760311 - content/html/content/test/forms/test_change_event.html ran additional tests after finish() was called
: content/html/content/test/forms/test_change_event.html ran additional tests a...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Layout: Form Controls (show other bugs)
: Trunk
: All All
: -- minor (vote)
: mozilla15
Assigned To: Mats Palmgren (:mats)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-31 16:08 PDT by Mats Palmgren (:mats)
Modified: 2012-06-02 12:03 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Add a setTimeout to workaround <input type=file> blur issues, and actually call MockFilePicker.cleanup(). (2.14 KB, patch)
2012-05-31 16:16 PDT, Mats Palmgren (:mats)
bzbarsky: review+
Details | Diff | Splinter Review
Fix DOS line endings. (12.27 KB, patch)
2012-05-31 16:17 PDT, Mats Palmgren (:mats)
bzbarsky: review+
Details | Diff | Splinter Review

Description Mats Palmgren (:mats) 2012-05-31 16:08:50 PDT
Fallout from the diagnostic patch in bug 677964.
Comment 1 Mats Palmgren (:mats) 2012-05-31 16:16:17 PDT
Created attachment 628944 [details] [diff] [review]
Add a setTimeout to workaround <input type=file> blur issues, and actually call MockFilePicker.cleanup().
Comment 2 Mats Palmgren (:mats) 2012-05-31 16:17:14 PDT
Created attachment 628946 [details] [diff] [review]
Fix DOS line endings.
Comment 3 Boris Zbarsky [:bz] 2012-05-31 18:24:43 PDT
Comment on attachment 628944 [details] [diff] [review]
Add a setTimeout to workaround <input type=file> blur issues, and actually call MockFilePicker.cleanup().

r=me
Comment 4 Boris Zbarsky [:bz] 2012-05-31 18:25:51 PDT
Comment on attachment 628946 [details] [diff] [review]
Fix DOS line endings.

r=me
Comment 5 Mounir Lamouri (:mounir) 2012-06-01 00:49:03 PDT
Comment on attachment 628944 [details] [diff] [review]
Add a setTimeout to workaround <input type=file> blur issues, and actually call MockFilePicker.cleanup().

Review of attachment 628944 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/html/content/test/forms/test_change_event.html
@@ -133,5 @@
>      input.click();
>      input.blur();
>      is(NonTextInputChange[5], 1, "Change event shouldn't be dispatched for checkbox ---> text input type change");
>  
> -    MockFilePicker.cleanup;

Why did you remove that? AFAIK, it is necessary.
Comment 6 Mats Palmgren (:mats) 2012-06-01 03:43:32 PDT
(In reply to Mounir Lamouri (:volkmar) (:mounir) from comment #5)
> -    MockFilePicker.cleanup;
> Why did you remove that? AFAIK, it is necessary.

I didn't remove it, I moved it closer to where it's used and changed it
to MockFilePicker.cleanup().  It wasn't being called before.
Comment 7 Mounir Lamouri (:mounir) 2012-06-01 05:32:59 PDT
Comment on attachment 628944 [details] [diff] [review]
Add a setTimeout to workaround <input type=file> blur issues, and actually call MockFilePicker.cleanup().

Review of attachment 628944 [details] [diff] [review]:
-----------------------------------------------------------------

Very sorry about that :(

Note You need to log in before you can comment on or make changes to this bug.