Closed Bug 760311 Opened 9 years ago Closed 9 years ago

content/html/content/test/forms/test_change_event.html ran additional tests after finish() was called

Categories

(Core :: Layout: Form Controls, defect)

defect
Not set
minor

Tracking

()

RESOLVED FIXED
mozilla15

People

(Reporter: mats, Assigned: mats)

Details

Attachments

(2 files)

Fallout from the diagnostic patch in bug 677964.
Attachment #628946 - Flags: review?(bzbarsky)
Comment on attachment 628944 [details] [diff] [review]
Add a setTimeout to workaround <input type=file> blur issues, and actually call MockFilePicker.cleanup().

r=me
Attachment #628944 - Flags: review?(bzbarsky) → review+
Comment on attachment 628946 [details] [diff] [review]
Fix DOS line endings.

r=me
Attachment #628946 - Flags: review?(bzbarsky) → review+
Comment on attachment 628944 [details] [diff] [review]
Add a setTimeout to workaround <input type=file> blur issues, and actually call MockFilePicker.cleanup().

Review of attachment 628944 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/html/content/test/forms/test_change_event.html
@@ -133,5 @@
>      input.click();
>      input.blur();
>      is(NonTextInputChange[5], 1, "Change event shouldn't be dispatched for checkbox ---> text input type change");
>  
> -    MockFilePicker.cleanup;

Why did you remove that? AFAIK, it is necessary.
Attachment #628944 - Flags: review-
(In reply to Mounir Lamouri (:volkmar) (:mounir) from comment #5)
> -    MockFilePicker.cleanup;
> Why did you remove that? AFAIK, it is necessary.

I didn't remove it, I moved it closer to where it's used and changed it
to MockFilePicker.cleanup().  It wasn't being called before.
Comment on attachment 628944 [details] [diff] [review]
Add a setTimeout to workaround <input type=file> blur issues, and actually call MockFilePicker.cleanup().

Review of attachment 628944 [details] [diff] [review]:
-----------------------------------------------------------------

Very sorry about that :(
Attachment #628944 - Flags: review-
You need to log in before you can comment on or make changes to this bug.