760311 - content/html/content/test/forms/test_change_event.html ran additional tests after finish() was called

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Mats Palmgren (inactive)]

Fallout from the diagnostic patch in bug 677964.

Comment 1

[Mats Palmgren (inactive)]

Attachment: Add a setTimeout to workaround <input type=file> blur issues, and actually call MockFilePicker.cleanup().

Comment 2

[Mats Palmgren (inactive)]

Attachment: Fix DOS line endings.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 628944 [details] [diff] [review]
Add a setTimeout to workaround <input type=file> blur issues, and actually call MockFilePicker.cleanup().

r=me

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 628946 [details] [diff] [review]
Fix DOS line endings.

r=me

Comment 5

[Mounir Lamouri (:mounir)]

Comment on attachment 628944 [details] [diff] [review]
Add a setTimeout to workaround <input type=file> blur issues, and actually call MockFilePicker.cleanup().

Review of attachment 628944 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/html/content/test/forms/test_change_event.html
@@ -133,5 @@
>      input.click();
>      input.blur();
>      is(NonTextInputChange[5], 1, "Change event shouldn't be dispatched for checkbox ---> text input type change");
>  
> -    MockFilePicker.cleanup;

Why did you remove that? AFAIK, it is necessary.

Comment 6

[Mats Palmgren (inactive)]

(In reply to Mounir Lamouri (:volkmar) (:mounir) from comment #5)
> -    MockFilePicker.cleanup;
> Why did you remove that? AFAIK, it is necessary.

I didn't remove it, I moved it closer to where it's used and changed it
to MockFilePicker.cleanup().  It wasn't being called before.

Comment 7

[Mounir Lamouri (:mounir)]

Comment on attachment 628944 [details] [diff] [review]
Add a setTimeout to workaround <input type=file> blur issues, and actually call MockFilePicker.cleanup().

Review of attachment 628944 [details] [diff] [review]:
-----------------------------------------------------------------

Very sorry about that :(

Comment 8

[Mats Palmgren (inactive)]

https://tbpl.mozilla.org/?usebuildbot=1&tree=Try&rev=5db9663b5473

Comment 9

[Mats Palmgren (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8c39ac876f64
https://hg.mozilla.org/integration/mozilla-inbound/rev/defd9a933da5

Comment 10

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/defd9a933da5
https://hg.mozilla.org/mozilla-central/rev/8c39ac876f64