The default bug view has changed. See this FAQ.

content/html/content/test/forms/test_change_event.html ran additional tests after finish() was called

RESOLVED FIXED in mozilla15

Status

()

Core
Layout: Form Controls
--
minor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mats, Assigned: mats)

Tracking

Trunk
mozilla15
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
Fallout from the diagnostic patch in bug 677964.
(Assignee)

Comment 1

5 years ago
Created attachment 628944 [details] [diff] [review]
Add a setTimeout to workaround <input type=file> blur issues, and actually call MockFilePicker.cleanup().
Attachment #628944 - Flags: review?(bzbarsky)
(Assignee)

Comment 2

5 years ago
Created attachment 628946 [details] [diff] [review]
Fix DOS line endings.
Attachment #628946 - Flags: review?(bzbarsky)
Comment on attachment 628944 [details] [diff] [review]
Add a setTimeout to workaround <input type=file> blur issues, and actually call MockFilePicker.cleanup().

r=me
Attachment #628944 - Flags: review?(bzbarsky) → review+
Comment on attachment 628946 [details] [diff] [review]
Fix DOS line endings.

r=me
Attachment #628946 - Flags: review?(bzbarsky) → review+
Comment on attachment 628944 [details] [diff] [review]
Add a setTimeout to workaround <input type=file> blur issues, and actually call MockFilePicker.cleanup().

Review of attachment 628944 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/html/content/test/forms/test_change_event.html
@@ -133,5 @@
>      input.click();
>      input.blur();
>      is(NonTextInputChange[5], 1, "Change event shouldn't be dispatched for checkbox ---> text input type change");
>  
> -    MockFilePicker.cleanup;

Why did you remove that? AFAIK, it is necessary.
Attachment #628944 - Flags: review-
(Assignee)

Comment 6

5 years ago
(In reply to Mounir Lamouri (:volkmar) (:mounir) from comment #5)
> -    MockFilePicker.cleanup;
> Why did you remove that? AFAIK, it is necessary.

I didn't remove it, I moved it closer to where it's used and changed it
to MockFilePicker.cleanup().  It wasn't being called before.
Comment on attachment 628944 [details] [diff] [review]
Add a setTimeout to workaround <input type=file> blur issues, and actually call MockFilePicker.cleanup().

Review of attachment 628944 [details] [diff] [review]:
-----------------------------------------------------------------

Very sorry about that :(
Attachment #628944 - Flags: review-
(Assignee)

Comment 8

5 years ago
https://tbpl.mozilla.org/?usebuildbot=1&tree=Try&rev=5db9663b5473
(Assignee)

Comment 9

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/8c39ac876f64
https://hg.mozilla.org/integration/mozilla-inbound/rev/defd9a933da5
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/defd9a933da5
https://hg.mozilla.org/mozilla-central/rev/8c39ac876f64
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.