76034 - saveURI api busted

Status: VERIFIED FIXED

(Core Graveyard :: Embedding: APIs, defect)

Description

[Marco Pesenti Gritti]

Saving images with this api is no more working in mozilla cvs:

/mozilla/embedding/browser/webBrowser/nsIWebBrowserPersist.idl
void saveURI(in nsIURI aURI, in nsIInputStream aPostData, in string aFileName);

I think it can be caused by this change: (the date is near when I noticed the
bug, and it seems related)

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/embedding/browser/webBrowser&command=DIFF_FRAMESET&file=nsWebBrowserPersist.cpp&rev1=1.11&rev2=1.12&root=/cvsroot

I can reproduce on this url for example:

http://www.gnome.org/images/banner-gnomeis

Comment 1

[Adam Lock]

Hi, do you have the Mozilla source? Can you try deleting the line 
"persist->Release();" from the method nsWebBrowser::SaveURI in 
mozilla/embedding/browser/webBrowser/nsWebBrowser.cpp and see if that fixes your 
problems?

I recently changed how the refcounting behaviour works and it's possible that 
the line is the cause of your problems. If so let me know and I will submit a 
patch.

Comment 2

[Marco Pesenti Gritti]

Hi,
Removing persist->Release () fix it.
It would be really good if this could be checked in before 0.9 :)

Comment 3

[Adam Lock]

Attachment: One line patch

Comment 4

[Adam Lock]

The 0.9 freeze is tonight but I will try and sneak it in since I have another 
patch on that file to checkin as well. It's very low risk.

Comment 5

[Adam Lock]

Fix is checked in.

Comment 6

[Michael Dunn]

Correction: Changing QA contact for the Embed API bugs to David Epstein.

Comment 7

[David Epstein]

changed qa contact to dsirnapalli. He's working with nsIWebBrowserPersist.

Comment 8

[dsirnapalli]

checked nsWebBrowser.cpp. line "persist->Release();" no longer exists in  method 
SaveURI. marking it  to verified.