760389 - always clobber all release builds

Status: RESOLVED FIXED

(Release Engineering :: Release Automation, defect, P2)

Description

[Nick Thomas [:nthomas] (UTC+12)]

Log:
http://buildbot-master34.build.mozilla.org:8001/builders/release-comm-esr10-thunderbird_source/builds/1/steps/checking_clobber_times/logs/stdio

I'd set any master/release-comm-esr10/any builder on clobberer, and got the same slaves as build1 (mv-moz2-linux-ix-slave02).

Checking clobber URL: http://build.mozilla.org/clobberer/index.php?master=http%3A%2F%2Fbuildbot-master34.srv.releng.scl3.mozilla.com%3A8001%2F&slave=mv-moz2-linux-ix-slave02&builddir=tb-rel-comm-esr10-thunderbird-source&branch=comm-esr10&buildername=release-comm-esr10-thunderbird_source
...
tb-rel-comm-esr10-thunderbird-source:Our last clobber date:  2012-05-31 19:30:59
tb-rel-comm-esr10-thunderbird-source:Server clobber date:    None

19:30 was build1.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

tag did clobber:
Checking clobber URL: http://build.mozilla.org/clobberer/index.php?master=http%3A%2F%2Fbuildbot-master34.srv.releng.scl3.mozilla.com%3A8001%2F&slave=mv-moz2-linux-ix-slave09&builddir=rel-comm-esr10-thunderbird-tag&branch=release-comm-esr10&buildername=release-comm-esr10-thunderbird_tag
rel-comm-esr10-thunderbird-tag:Our last clobber date:  2012-05-31 19:13:59
rel-comm-esr10-thunderbird-tag:Server clobber date:    2012-06-01 01:11:39
rel-comm-esr10-thunderbird-tag:Server is forcing a clobber, initiated by [e-mail]
rel-comm-esr10-thunderbird-tag:Clobbering...

linux build did not:
Checking clobber URL: http://build.mozilla.org/clobberer/index.php?master=http%3A%2F%2Fbuildbot-master34.srv.releng.scl3.mozilla.com%3A8001%2F&slave=mv-moz2-linux-ix-slave09&builddir=tb-rel-comm-esr10-lnx-bld&branch=comm-esr10&buildername=release-comm-esr10-linux_build
tb-rel-comm-esr10-lnx-bld:Our last clobber date:  2012-05-31 19:30:58
tb-rel-comm-esr10-lnx-bld:Server clobber date:    None

All sorts of differences in builddir, branch, and buildername format.

Comment 2

[[e-mail] (:bhearsum)]

Rail or John, can one of you have a look at this?

Comment 3

[Rail Aliiev [:rail]]

branch=release-comm-esr10 vs branch=comm-esr10

Comment 4

[Rail Aliiev [:rail]]

Attachment: Use clobberBranch explicitly

self.branchName is passed as branch to clobberer, while we expect that to be 'release-%s' % self.branchName for releases. Passing branchName set to 'release-%s' % sourceRepoInfo['name'] to factories looks dangerous, so I added another parameter.

To be tested in staging

Comment 5

[Aki Sasaki (not active)]

Attachment: always_clobber all releases

Comment 6

[Rail Aliiev [:rail]]

Comment on attachment 631085 [details] [diff] [review]
always_clobber all releases

Die, manual clobber, die!

Comment 7

[Aki Sasaki (not active)]

Comment on attachment 631085 [details] [diff] [review]
always_clobber all releases

http://hg.mozilla.org/build/buildbot-configs/rev/fbe37cddb8bf

Comment 8

[Rail Aliiev [:rail]]

I checked Firefox builders and they also look affected.

Affected builders are *-source, *-build, updates, final verification. ScriptFactory based builders are OK.

I also tested the patch in staging and it fixed the branch parameter passed to clobberer.

Comment 9

[Rail Aliiev [:rail]]

Comment on attachment 631075 [details] [diff] [review]
Use clobberBranch explicitly

http://hg.mozilla.org/build/buildbotcustom/rev/86dd2d12fa51

Comment 10

[Armen [:armenzg]]

This code has been merged to the production branch and masters have been reconfigured around 7:40 AM PDT.