760451 - [AccessFu] Support skip links

Status: VERIFIED FIXED

(Core :: Disability Access APIs, defect)

Description

[Eitan Isaacson [:eeejay]]

Sites will often have links that skip to anchors in the site. We should move the virtual cursor to the anchor.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Support skip links

This uses EVENT_SCROLLING_START, which is a curious name, but seems to do what we need.

Comment 2

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 629198 [details] [diff] [review]
Support skip links

Review of attachment 629198 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/jsat/AccessFu.jsm
@@ +351,5 @@
>          }
>          break;
>        }
> +      case Ci.nsIAccessibleEvent.EVENT_SCROLLING_START:
> +      {

Yeah, strange but true - this seems to be the event to watch. I wonder why we didn't call it something related to anchors...

::: accessible/src/jsat/VirtualCursorController.jsm
@@ +174,5 @@
> +      } catch (x) {
> +        doc = doc.parentDocument;
> +        continue;
> +      }
> +      vc.moveNext(aRule || this.SimpleTraversalRule, aAccessible, true);

Will this throw a type error if vc is null? (Can vc be null here?)

Comment 3

[Eitan Isaacson [:eeejay]]

(In reply to David Bolter [:davidb] from comment #2)
> Comment on attachment 629198 [details] [diff] [review]
> Support skip links
> 
> Review of attachment 629198 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: accessible/src/jsat/VirtualCursorController.jsm
> @@ +174,5 @@
> > +      } catch (x) {
> > +        doc = doc.parentDocument;
> > +        continue;
> > +      }
> > +      vc.moveNext(aRule || this.SimpleTraversalRule, aAccessible, true);
> 
> Will this throw a type error if vc is null? (Can vc be null here?)

If it has the cursorable interface, it should always have a virtual cursor. But null checking would not be such a bad practice here, so I could add that.

Comment 4

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 629198 [details] [diff] [review]
Support skip links

Review of attachment 629198 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the null check thanks.

Comment 5

[David Bolter [:davidb] (NeedInfo me for attention)]

Wait, there are no cases it wouldn't have a vc? If so then no null check is fine.

Comment 6

[Eitan Isaacson [:eeejay]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/48a60f4f7264

Comment 7

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/48a60f4f7264

Comment 8

[Marco Zehe (:MarcoZ)]

Verified fixed in Fennec/Android 16.0a1 2012/06/05.