Closed Bug 760458 Opened 12 years ago Closed 12 years ago

Thumbnails of RTL pages have black space

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox14 fixed, firefox15 verified, firefox16 verified, blocking-fennec1.0 .N+)

Status:
VERIFIED FIXED
Milestone:
Firefox 15
Tracking Flags:
Tracking Status
firefox14 --- fixed
firefox15 --- verified
firefox16 --- verified
blocking-fennec1.0 --- .N+

People

(Reporter: kats, Assigned: kats)

References

Details

Attachments

(2 files)

Screenshot of about:home
536.60 KB, image/png
Details
Use GetRootBounds instead of GetScrollWidth/GetScrollHeight
2.96 KB, patch
bnicholson
: review+
mfinkle
: approval-mozilla-beta+
Details | Diff | Splinter Review
See attached screenshot; the bottom-right thumbnail is of an RTL page (http://www.bbc.co.uk/persian/mobile/index.shtml) and has a bunch of black space. I believe the code in AndroidBridge::TakeScreenshot that calls GetScrollWidth and GetScrollHeight to calculate srcW and srcH also needs to update srcX and srcY to be the top-left corner of the page (it currently assumes 0,0 is top-left).
Not a 14 blocker, but we'd like to approve a patch
blocking-fennec1.0: ? → .N+
Comment on attachment 629311 [details] [diff] [review] Use GetRootBounds instead of GetScrollWidth/GetScrollHeight This works fine, even on my weird RAZR.
Attachment #629311 - Flags: review?(bnicholson) → review+
Sorry, I had to back this out on inbound because the patch depends on bug 755070 which was backed out for crashes: https://hg.mozilla.org/integration/mozilla-inbound/rev/d7b8fe3834b9
status-firefox15: fixed → affected
Depends on: 755070
Target Milestone: Firefox 15 → ---
Re-landed since it doesn't functionally depend on bug 755070, it just needs some hand-merging. https://hg.mozilla.org/integration/mozilla-inbound/rev/8afb46816482
status-firefox15: affected → fixed
Target Milestone: --- → Firefox 15
No longer depends on: 755070
https://hg.mozilla.org/mozilla-central/rev/9a44997a3752
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Backed out: https://hg.mozilla.org/mozilla-central/rev/d7b8fe3834b9
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
https://hg.mozilla.org/mozilla-central/rev/8afb46816482
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
Comment on attachment 629311 [details] [diff] [review] Use GetRootBounds instead of GetScrollWidth/GetScrollHeight [Approval Request Comment] Bug caused by (feature/regressing bug #): 748384 User impact if declined: thumbnails on about:home for RTL pages may not render properly Testing completed (on m-c, etc.): on m-c Risk to taking this patch (and alternatives if risky): low risk of screwing up thumbnails in general. android-only String or UUID changes made by this patch: none
Attachment #629311 - Flags: approval-mozilla-aurora?
Attachment #629311 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment on attachment 629311 [details] [diff] [review] Use GetRootBounds instead of GetScrollWidth/GetScrollHeight Clearing aurora approval flag since this just rode the train from m-c into Aurora. Requesting beta approval instead (i.e. approval to land on the 14 branch).
Attachment #629311 - Flags: approval-mozilla-aurora+ → approval-mozilla-beta?
Attachment #629311 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Thumbnails are not displayed on Aurora 15.0a2 2012-06-07, Nightly 16.0a1 2012-06-08 and Firefox Mobile Beta 14.0b6. Bug 762899 tracks the issue. Leaving the bug open since it can't be verified.
Depends on: 762899
Status: RESOLVED → VERIFIED
status-firefox15: fixed → verified
status-firefox16: --- → verified
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: