Closed
Bug 760614
Opened 13 years ago
Closed 13 years ago
Retry on connection failures, to address transient network errors
Categories
(Firefox for Android Graveyard :: Android Sync, defect, P1)
Tracking
(firefox14 fixed, firefox15 fixed, blocking-fennec1.0 +)
RESOLVED
FIXED
mozilla16
People
(Reporter: liuche, Assigned: liuche)
References
Details
(Whiteboard: [sync], [qa+])
Attachments
(1 file)
|
2.48 KB,
patch
|
blassey
:
approval-mozilla-aurora+
blassey
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
This should also fix Bug 760360, which involves syncing on an unreliable network.
If the connection is closed while we process downloaded records, the sync fails. We should be more optimistic, because on unreliable networks, a simple retry of the connection should allow us to complete the sync.
|
||
Updated•13 years ago
|
tracking-fennec: --- → ?
|
|
||
Updated•13 years ago
|
Whiteboard: [sync, fix for 760360]
|
|
||
Updated•13 years ago
|
tracking-fennec: ? → -
blocking-fennec1.0: --- → ?
|
|
||
Comment 1•13 years ago
|
||
mobile triage: blocks, duping tony's bug to here
tracking-fennec: - → ---
blocking-fennec1.0: ? → +
|
|
||
Updated•13 years ago
|
Whiteboard: [sync, fix for 760360] → [sync][work in progress]
|
|
||
Updated•13 years ago
|
Priority: -- → P1
|
||
Updated•13 years ago
|
Status: NEW → ASSIGNED
OS: Mac OS X → Android
Hardware: x86 → ARM
|
|
||
Updated•13 years ago
|
|
|
||
Updated•13 years ago
|
Whiteboard: [sync][work in progress] → [sync][needs review: nalexander]
|
||
Updated•13 years ago
|
Whiteboard: [sync][needs review: nalexander] → [sync]
|
|
||
Comment 3•13 years ago
|
||
|
|
||
Comment 4•13 years ago
|
||
|
||
Updated•13 years ago
|
Target Milestone: --- → mozilla16
|
||
Comment 5•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•13 years ago
|
Attachment #630021 -
Attachment is patch: true
|
|
||
Comment 6•13 years ago
|
||
Comment on attachment 630021 [details] [diff] [review]
Patch against m-i
[Approval Request Comment]
Bug caused by (feature/regressing bug #):
User impact if declined: transient network errors cause missed syncs
Testing completed (on m-c, etc.): builds m-c and aurora
Risk to taking this patch (and alternatives if risky): low, patch is straightforward.
String or UUID changes made by this patch: none
Attachment #630021 -
Flags: approval-mozilla-beta?
Attachment #630021 -
Flags: approval-mozilla-aurora?
|
||
Updated•13 years ago
|
Attachment #630021 -
Flags: approval-mozilla-beta?
Attachment #630021 -
Flags: approval-mozilla-beta+
Attachment #630021 -
Flags: approval-mozilla-aurora?
Attachment #630021 -
Flags: approval-mozilla-aurora+
|
|
||
Comment 7•13 years ago
|
||
status-firefox14:
--- → fixed
|
|
||
Comment 8•13 years ago
|
||
status-firefox15:
--- → fixed
|
|
||
Comment 9•13 years ago
|
||
Chenxia, how can this be verified? at the very least, i'll retry my STR in bug 760360 from my home network next build.
Whiteboard: [sync] → [sync], [qa+]
|
|
||
Comment 10•13 years ago
|
||
(In reply to Tony Chung [:tchung] from comment #9)
> Chenxia, how can this be verified? at the very least, i'll retry my STR in
> bug 760360 from my home network next build.
In the general case, you'll need an environment that induces transient network errors.
In this specific case, you're looking for an environment like your home network -- one that seems to drop idle connections quite rapidly.
|
||
Comment 11•13 years ago
|
||
Still on the radar for verification on mozilla-15
|
||
Updated•12 years ago
|
Product: Mozilla Services → Android Background Services
|
||
Updated•8 years ago
|
Product: Android Background Services → Firefox for Android
|
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•