760643 - Device Storage - Delete isn't working

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Doug Turner (:dougt)]

Currently Delete() is silently failing.  I am going to change the code to test for existence after delete and fire an onError if the file continues to exists.

We are also incorrectly calculating the path of storage.  I am going to clean up our DeviceStorageFile to always clone() the nsIFile to avoid such problems.

Comment 1

[Doug Turner (:dougt)]

Attachment: patch v.1

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 629317 [details] [diff] [review]
patch v.1

Review of attachment 629317 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/devicestorage/nsDeviceStorage.cpp
@@ +43,5 @@
> +    nsCOMPtr<nsIFile> file;
> +    aFile->Clone(getter_AddRefs(mFile));
> +  }
> +  nsCOMPtr<nsIFile> mFile;
> +  nsString mPath;

Put these first or last. Keeping them in the middle makes them hard to find.

Comment 3

[Doug Turner (:dougt)]

last patch broke windows.  fixed up the path, pushed to try, and its good now.  results should be coming soon.

Comment 4

[Doug Turner (:dougt)]

try:
  https://tbpl.mozilla.org/?tree=Try&rev=aaa30a35850f

inbound:
  https://hg.mozilla.org/integration/mozilla-inbound/rev/efa54ecee724

Comment 5

[Geoff Lankow (:darktrojan)]

https://hg.mozilla.org/mozilla-central/rev/efa54ecee724