Device Storage - Delete isn't working

RESOLVED FIXED in mozilla16

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dougt, Assigned: dougt)

Tracking

unspecified
mozilla16
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Currently Delete() is silently failing.  I am going to change the code to test for existence after delete and fire an onError if the file continues to exists.

We are also incorrectly calculating the path of storage.  I am going to clean up our DeviceStorageFile to always clone() the nsIFile to avoid such problems.
(Assignee)

Comment 1

5 years ago
Created attachment 629317 [details] [diff] [review]
patch v.1
Attachment #629317 - Flags: review?(jonas)
Comment on attachment 629317 [details] [diff] [review]
patch v.1

Review of attachment 629317 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/devicestorage/nsDeviceStorage.cpp
@@ +43,5 @@
> +    nsCOMPtr<nsIFile> file;
> +    aFile->Clone(getter_AddRefs(mFile));
> +  }
> +  nsCOMPtr<nsIFile> mFile;
> +  nsString mPath;

Put these first or last. Keeping them in the middle makes them hard to find.
Attachment #629317 - Flags: review?(jonas) → review+
(Assignee)

Comment 3

5 years ago
last patch broke windows.  fixed up the path, pushed to try, and its good now.  results should be coming soon.
(Assignee)

Comment 4

5 years ago
try:
  https://tbpl.mozilla.org/?tree=Try&rev=aaa30a35850f

inbound:
  https://hg.mozilla.org/integration/mozilla-inbound/rev/efa54ecee724
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/efa54ecee724
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.