760696 - Use :fullscreen to detect HTML5 video/audio state for controls visibility

Status: RESOLVED INVALID

(Toolkit :: Video/Audio Controls, defect)

Description

[Frank Yan (:fryn)]

Attachment: patch

Use :fullscreen to detect HTML5 video/audio state for controls visibility.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 629351 [details] [diff] [review]
patch

This looks fine to me but you should get sign off from a layout peer before landing.

Comment 2

[Frank Yan (:fryn)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0fa8e0eb40a7

Comment 3

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/0fa8e0eb40a7

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Backout of patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): This bug and the patch for bug 713608
User impact if declined: Unable to turn off controls in fullscreen video
Testing completed (on m-c, etc.): backout of patch
Risk to taking this patch (and alternatives if risky): none expected
String or UUID changes made by this patch: none

This patch and the patch for bug 713608 are planned to be backed out with a new patch for bug 713608 on its way.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

See the discussion in bug 762903 (https://bugzilla.mozilla.org/show_bug.cgi?id=762903#c8) for more information here.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Backed out on mozilla-inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/aa4c97dbbef1

Changing to RESO-INVALID since the patch that caused this bug has also been backed out on inbound (713608). A new patch for bug 713608 is in the works.

Comment 7

[Ed Morley [:emorley]]

Backout merged:
https://hg.mozilla.org/mozilla-central/rev/aa4c97dbbef1

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Backed out of aurora:
https://hg.mozilla.org/releases/mozilla-aurora/rev/0eaa3e5f5604