The default bug view has changed. See this FAQ.

Isolate E4X jittests

RESOLVED FIXED in mozilla16

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: terrence, Assigned: terrence)

Tracking

Trunk
mozilla16
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 629369 [details] [diff] [review]
v0

With --disable-e4x, several jit-tests fail.  This reworks these tests to not use E4X, or if they are E4X specific, moves them to a separate e4x directory so they are easy to visually filter.

Most of these were fairly straightforward, however, I'm not 100% certain about the following tests and would like a second opinion:
  bug651966.js
  bug737251.js
  bug738846.js
Attachment #629369 - Flags: review?(jorendorff)
(Assignee)

Updated

5 years ago
Attachment #629369 - Flags: review?(jorendorff)
(Assignee)

Comment 1

5 years ago
Created attachment 629969 [details] [diff] [review]
v1: Part1 - Move e4x specfic tests to e4x directory.

This is incredibly tedious, so I'm going to split it into two parts.  This first part is just the tests that are specific to E4X -- e.g. the messed up moves from the last patch.
Attachment #629369 - Attachment is obsolete: true
Attachment #629969 - Flags: review?(jorendorff)
Attachment #629969 - Flags: review?(jorendorff) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/ad8edddea8d3

Coolest changeset hash ever.
https://hg.mozilla.org/mozilla-central/rev/ad8edddea8d3

(Merged by Ed Morley)
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.