Closed Bug 760752 Opened 8 years ago Closed 8 years ago

Frequent browser_dbg_debugger-tab-switch.js | leaked window property: _scriptDebugger and 87 more test failures

Categories

(DevTools :: Debugger, defect, P1)

Product:
DevTools
Component:
Debugger
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: philor, Unassigned)

References

Details

(Keywords: intermittent-failure, Whiteboard: [fixed-in-fx-team])

Attachments

(1 file, 1 obsolete file)

potential fix
6.44 KB, patch
past
: review+
Details | Diff | Splinter Review 
This very much needs to not merge to Aurora on Monday.

According to edmorley's retriggering on fx-team, it most likely started with https://tbpl.mozilla.org/?tree=Fx-Team&rev=96a7cf29e588 which included the patch for bug 753311 which moved _scriptDebugger around, which makes it seem like a very good candidate.

https://tbpl.mozilla.org/php/getParsedLog.php?id=12278364&tree=Fx-Team
Rev3 WINNT 5.1 fx-team pgo test mochitest-other on 2012-06-01 09:04:29 PDT for push 96a7cf29e588
slave: talos-r3-xp-028

TEST-PASS | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_debugger-tab-switch.js | Shouldn't have a tab switch notification.
TEST-INFO | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_debugger-tab-switch.js | Second debugger has loaded.
TEST-INFO | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_debugger-tab-switch.js | Console message: [JavaScript Error: "self._transport is null" {file: "resource://gre/modules/devtools/dbg-client.jsm" line: 368}]
TEST-INFO | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_debugger-tab-switch.js | Console message: [JavaScript Error: "TypeError: this._scripts is null" {file: "chrome://browser/content/debugger-view.js" line: 475}]
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_debugger-tab-switch.js | leaked window property: _scriptDebugger
INFO TEST-END | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_debugger-tab-switch.js | finished in 1479ms
TEST-INFO | checking window state
TEST-START | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_debuggerstatement.js
TEST-PASS | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_debuggerstatement.js | Should trigger the pause handler on a debugger statement.
TEST-INFO | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_debuggerstatement.js | Console message: [JavaScript Error: "[Exception... "Component returned failure code: 0x80470002 (NS_BASE_STREAM_CLOSED) [nsIOutputStream.write]"  nsresult: "0x80470002 (NS_BASE_STREAM_CLOSED)"  location: "JS frame :: chrome://global/content/devtools/dbg-transport.js :: DT_onOutputStreamReady :: line 94"  data: no]" {file: "chrome://global/content/devtools/dbg-transport.js" line: 94}]
INFO TEST-END | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_debuggerstatement.js | finished in 361ms
TEST-INFO | checking window state
TEST-START | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_displayName.js
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_displayName.js | Test timed out
(screenshot)
...
on and on

https://tbpl.mozilla.org/php/getParsedLog.php?id=12265872&tree=Fx-Team
https://tbpl.mozilla.org/php/getParsedLog.php?id=12270249&tree=Fx-Team
https://tbpl.mozilla.org/php/getParsedLog.php?id=12295540&tree=Fx-Team
https://tbpl.mozilla.org/php/getParsedLog.php?id=12287614&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=12289762&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=12284445&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=12291837&tree=Mozilla-Inbound
(the latter two being the start of non-WinXP)
Pushed an investigatory backout to try in https://tbpl.mozilla.org/?tree=Try&rev=71b6b7e31589 (but good luck to me getting Windows builds)
Which, alas, says that there's dependent stuff landed on top of it.
Attached patch potential fix — — Splinter Review 
Here's a fix that works for me.  Panos, Victor, you might be able to see a better approach...

https://tbpl.mozilla.org/?tree=Try&rev=63f124de24ac
Attached patch potential fix fix (obsolete) — — Splinter Review 
Dave's approach looks good.
Added commit message and removed extra dumps & bad formatting.
Comment on attachment 629456 [details] [diff] [review]
potential fix

Review of attachment 629456 [details] [diff] [review]:
-----------------------------------------------------------------

Try runs look green, I'm going to land this.
Attachment #629456 - Flags: review+
Attachment #629461 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/8caca2dc3ec1
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [orange][fixed-in-fx-team] → [fixed-in-fx-team]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.