|
6.44 KB,
patch
|
past
:
review+
|
Details | Diff | Splinter Review |
This very much needs to not merge to Aurora on Monday. According to edmorley's retriggering on fx-team, it most likely started with https://tbpl.mozilla.org/?tree=Fx-Team&rev=96a7cf29e588 which included the patch for bug 753311 which moved _scriptDebugger around, which makes it seem like a very good candidate. https://tbpl.mozilla.org/php/getParsedLog.php?id=12278364&tree=Fx-Team Rev3 WINNT 5.1 fx-team pgo test mochitest-other on 2012-06-01 09:04:29 PDT for push 96a7cf29e588 slave: talos-r3-xp-028 TEST-PASS | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_debugger-tab-switch.js | Shouldn't have a tab switch notification. TEST-INFO | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_debugger-tab-switch.js | Second debugger has loaded. TEST-INFO | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_debugger-tab-switch.js | Console message: [JavaScript Error: "self._transport is null" {file: "resource://gre/modules/devtools/dbg-client.jsm" line: 368}] TEST-INFO | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_debugger-tab-switch.js | Console message: [JavaScript Error: "TypeError: this._scripts is null" {file: "chrome://browser/content/debugger-view.js" line: 475}] TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_debugger-tab-switch.js | leaked window property: _scriptDebugger INFO TEST-END | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_debugger-tab-switch.js | finished in 1479ms TEST-INFO | checking window state TEST-START | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_debuggerstatement.js TEST-PASS | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_debuggerstatement.js | Should trigger the pause handler on a debugger statement. TEST-INFO | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_debuggerstatement.js | Console message: [JavaScript Error: "[Exception... "Component returned failure code: 0x80470002 (NS_BASE_STREAM_CLOSED) [nsIOutputStream.write]" nsresult: "0x80470002 (NS_BASE_STREAM_CLOSED)" location: "JS frame :: chrome://global/content/devtools/dbg-transport.js :: DT_onOutputStreamReady :: line 94" data: no]" {file: "chrome://global/content/devtools/dbg-transport.js" line: 94}] INFO TEST-END | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_debuggerstatement.js | finished in 361ms TEST-INFO | checking window state TEST-START | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_displayName.js TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_displayName.js | Test timed out (screenshot) ... on and on https://tbpl.mozilla.org/php/getParsedLog.php?id=12265872&tree=Fx-Team https://tbpl.mozilla.org/php/getParsedLog.php?id=12270249&tree=Fx-Team https://tbpl.mozilla.org/php/getParsedLog.php?id=12295540&tree=Fx-Team https://tbpl.mozilla.org/php/getParsedLog.php?id=12287614&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=12289762&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=12284445&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=12291837&tree=Mozilla-Inbound (the latter two being the start of non-WinXP)
|
(Reporter) | |
Comment 1•5 years ago
|
||
Pushed an investigatory backout to try in https://tbpl.mozilla.org/?tree=Try&rev=71b6b7e31589 (but good luck to me getting Windows builds)
|
|
(Reporter) | |
Comment 2•5 years ago
|
||
Which, alas, says that there's dependent stuff landed on top of it.
|
|
(Reporter) | |
Comment 3•5 years ago
|
||
https://tbpl.mozilla.org/php/getParsedLog.php?id=12294297&tree=Profiling
|
|
(Reporter) | |
Comment 4•5 years ago
|
||
https://tbpl.mozilla.org/php/getParsedLog.php?id=12299139&tree=Mozilla-Inbound
| Comment hidden (Treeherder Robot) |
|
||
Comment 6•5 years ago
|
||
Created attachment 629456 [details] [diff] [review] potential fix Here's a fix that works for me. Panos, Victor, you might be able to see a better approach... https://tbpl.mozilla.org/?tree=Try&rev=63f124de24ac
|
||
Comment 7•5 years ago
|
||
Created attachment 629461 [details] [diff] [review] potential fix fix Dave's approach looks good. Added commit message and removed extra dumps & bad formatting.
|
|
(Reporter) | |
Comment 8•5 years ago
|
||
https://tbpl.mozilla.org/php/getParsedLog.php?id=12302213&tree=Mozilla-Inbound
|
|
(Reporter) | |
Comment 9•5 years ago
|
||
https://tbpl.mozilla.org/php/getParsedLog.php?id=12303723&tree=Mozilla-Inbound
|
||
Comment 10•5 years ago
|
||
Comment on attachment 629456 [details] [diff] [review] potential fix Review of attachment 629456 [details] [diff] [review]: ----------------------------------------------------------------- Try runs look green, I'm going to land this.
|
|
||
Comment 11•5 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/8caca2dc3ec1
|
|
||
Updated•5 years ago
|
||
|
|
(Reporter) | |
Comment 12•5 years ago
|
||
https://tbpl.mozilla.org/php/getParsedLog.php?id=12311148&tree=Mozilla-Inbound
|
|
(Reporter) | |
Comment 13•5 years ago
|
||
https://tbpl.mozilla.org/php/getParsedLog.php?id=12314274&tree=Mozilla-Inbound
|
|
||
Comment 14•5 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8caca2dc3ec1
|
(Assignee) | |
Updated•5 years ago
|
||
|
|
(Assignee) | |
Updated•5 years ago
|
||
Description
•