switch ARIA role map to atoms

RESOLVED FIXED in mozilla16

Status

()

Core
Disability Access APIs
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: surkov, Assigned: surkov)

Tracking

(Blocks: 1 bug)

unspecified
mozilla16
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

30.19 KB, patch
tbsaunde
: review+
neil@parkwaycc.co.uk
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

5 years ago
Created attachment 629454 [details] [diff] [review]
patch
Attachment #629454 - Flags: superreview?(neil)
Attachment #629454 - Flags: review?(trev.saunders)
Comment on attachment 629454 [details] [diff] [review]
patch

I'm not sure if the change to atoms will have a good or bad effect on perf for GetOrCreateAccessible() since on one hand no more convertion from utf16 to ascii, on the other we probably hurt locality some.  However I think if we find it matters we should replace binary search on special logic that knows the possible options.
Attachment #629454 - Flags: review?(trev.saunders) → review+
(Assignee)

Comment 2

5 years ago
Neil, could you check strings code please?

Comment 3

5 years ago
Comment on attachment 629454 [details] [diff] [review]
patch

>+  const nsDependentString ARIARoleString() const
>+    { return nsDependentAtomString(*roleAtom); }
Need to make the type of this function nsDependentAtomString too so that the compiler can perform RVO on it.
Attachment #629454 - Flags: superreview?(neil) → superreview+
(Assignee)

Comment 4

5 years ago
landed with Neil's comment fixed https://hg.mozilla.org/integration/mozilla-inbound/rev/f86a9695194c
Assignee: nobody → surkov.alexander
Flags: in-testsuite+
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/f86a9695194c

(Merged by Ed Morley)
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.