Closed
Bug 760774
Opened 14 years ago
Closed 14 years ago
switch ARIA role map to atoms
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: surkov, Assigned: surkov)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
30.19 KB,
patch
|
tbsaunde
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #629454 -
Flags: superreview?(neil)
Attachment #629454 -
Flags: review?(trev.saunders)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 629454 [details] [diff] [review]
patch
I'm not sure if the change to atoms will have a good or bad effect on perf for GetOrCreateAccessible() since on one hand no more convertion from utf16 to ascii, on the other we probably hurt locality some. However I think if we find it matters we should replace binary search on special logic that knows the possible options.
Attachment #629454 -
Flags: review?(trev.saunders) → review+
|
Assignee | |
Comment 2•14 years ago
|
||
Neil, could you check strings code please?
|
||
Comment 3•14 years ago
|
||
Comment on attachment 629454 [details] [diff] [review]
patch
>+ const nsDependentString ARIARoleString() const
>+ { return nsDependentAtomString(*roleAtom); }
Need to make the type of this function nsDependentAtomString too so that the compiler can perform RVO on it.
Attachment #629454 -
Flags: superreview?(neil) → superreview+
|
|
Assignee | |
Comment 4•14 years ago
|
||
landed with Neil's comment fixed https://hg.mozilla.org/integration/mozilla-inbound/rev/f86a9695194c
Assignee: nobody → surkov.alexander
Flags: in-testsuite+
Target Milestone: --- → mozilla16
|
||
Comment 5•14 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f86a9695194c
(Merged by Ed Morley)
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•