/var/SSD/TB-hg/mozilla/content/html/content/src/nsGenericHTMLElement.cpp: In function 'bool IsVoidTag(mozilla::dom::Element*)': /var/SSD/TB-hg/mozilla/content/html/content/src/nsGenericHTMLElement.cpp:1113:23: error: 'source' is not a member of 'nsGkAtoms' gmake: *** [nsGenericHTMLElement.o] Error 1
Created attachment 629464 [details] [diff] [review] patch
Would it be better to remove the #ifdef MOZ_MEDIA switches from the declaration in content/base/src/nsGkAtomList.h? The media-specific atoms are the only ones so conditionalized. And <track> is missing such a switch. Is space in the atom list so precious that it's worth maintaining this configuration difference?
If you propose only remove the switches from the nsGkAtomList.h declaration but not the rest of the code (so that the atoms are defined but never used), that would solve the occasional build breakage when somebody forgets those atoms are conditional on MOZ_MEDIA.
Created attachment 629474 [details] [diff] [review] alternate patch Yes, I meant just removing the #ifdef MOZ_MEDIA from the list of defined atoms.
Comment on attachment 629474 [details] [diff] [review] alternate patch I can confirm this fixes the build too. I do not use --disable-ogg (and others) to save run-time memory, but to not compile useless stuff (with build dependencies) and save compile time and ld memory. Because I build Thunderbird.
Comment on attachment 629474 [details] [diff] [review] alternate patch Ok, thanks. bz, what's your preference?
Comment on attachment 629474 [details] [diff] [review] alternate patch r=me, but note that the new DOM bindings for WebGLContext almost certainly don't compile without MOZ_MEDIA either: I was told that was not a supported configuration, and there is no real infrastructure in WebIDL to make methods conditional on compiler ifdefs at the moment...
5 years ago
Thanks. Ready to land.
For some reason it does work for me. Maybe TB does not compile webgl.
bz was right, after today's hg update WebGLRenderingContextBinding.cpp fails. So, is there a --disable-webgl mozconfig option?
There isn't, sorry. Note that once we convert 2d canvas to new bindings it would have the same problem: the canvas spec explicitly lists HTMLVideoElement as one of the overloads for drawImage. And I really doubt there will be a --disable-2d-canvas option...
Fortunately removing --disable-ogg does work for me (it enables MOZ_MEDIA). That is a pity the options are not there. I now must compile useless code (for TB). I'll try to file a bug for the options :)
(This didn't make it in time for 15).