Intermittent browser_webconsole_bug_595934_message_categories.js | expectUncaughtException was called but no uncaught exception was detected!

RESOLVED FIXED in Firefox 16

Status

()

Firefox
Developer Tools: Console
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: msucan, Assigned: msucan)

Tracking

({intermittent-failure})

Trunk
Firefox 16
intermittent-failure
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Assignee)

Description

5 years ago
Rev4 MacOSX Lion 10.7 fx-team opt test mochitest-other

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_webconsole_bug_595934_message_categories.js | expectUncaughtException was called but no uncaught exception was detected!

Push:
https://hg.mozilla.org/integration/fx-team/rev/05eeabb5db0a

Brief log:
https://tbpl.mozilla.org/php/getParsedLog.php?id=12311303&tree=Fx-Team
(Assignee)

Comment 1

5 years ago
Created attachment 629501 [details] [diff] [review]
proposed fix
(Assignee)

Comment 2

5 years ago
Created attachment 629502 [details] [diff] [review]
[in-fx-team] disable subtest
Attachment #629502 - Flags: review?(dcamp)
Attachment #629502 - Flags: review?(dcamp) → review+
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
(Assignee)

Comment 8

5 years ago
Comment on attachment 629502 [details] [diff] [review]
[in-fx-team] disable subtest

https://hg.mozilla.org/integration/fx-team/rev/ff4163e5f869
Attachment #629502 - Attachment description: disable subtest → [in-fx-team] disable subtest

Comment 9

5 years ago
https://hg.mozilla.org/mozilla-central/rev/ff4163e5f869

I'm leaving this open because Mihai mentioned that he wanted to fix the test for real.  Close if you decide otherwise please Mihai.
Comment hidden (Treeherder Robot)
(Assignee)

Comment 11

5 years ago
Created attachment 629573 [details] [diff] [review]
test fix - rebased

This is the test fix that I'd like us to land after the aurora merge.

Green runs:
https://tbpl.mozilla.org/?tree=Try&rev=9603af047508
Attachment #629501 - Attachment is obsolete: true
Attachment #629573 - Flags: review?(past)
Comment on attachment 629573 [details] [diff] [review]
test fix - rebased

Review of attachment 629573 [details] [diff] [review]:
-----------------------------------------------------------------

Yep, the plan seems solid. I suppose you could move it even further up if we ever get another similar failure.
Attachment #629573 - Flags: review?(past) → review+
Blocks: 438871
(Assignee)

Comment 13

5 years ago
Created attachment 632795 [details] [diff] [review]
[in-fx-team] test fix - improvements

The previous patch had no failures after many runs on the try server, but ultimately I was able to reproduce failures on my machine.

I had to make more changes, this is the patch I ended up with. No more failures on my machine.

Try push looks green again:
https://tbpl.mozilla.org/?tree=Try&rev=665e11e32550
Attachment #629573 - Attachment is obsolete: true
Attachment #632795 - Flags: review?(past)
Comment on attachment 632795 [details] [diff] [review]
[in-fx-team] test fix - improvements

Review of attachment 632795 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/webconsole/test/browser_webconsole_bug_595934_message_categories.js
@@ +159,5 @@
> +      },
> +      successFn: testNext,
> +      failureFn: function() {
> +        info("foundCategory " + foundCategory + " foundText " + foundText +
> +             "pageLoaded " + pageLoaded + " pageError " + pageError);

You probably want a space before pageLoaded inside the string literal.
Attachment #632795 - Flags: review?(past) → review+
(Assignee)

Comment 15

5 years ago
Comment on attachment 632795 [details] [diff] [review]
[in-fx-team] test fix - improvements

https://hg.mozilla.org/integration/fx-team/rev/dc4abc6cf76d

Thank you Panos. I fixed that in the patch I landed.
Attachment #632795 - Attachment description: test fix - improvements → [in-fx-team] test fix - improvements
(Assignee)

Updated

5 years ago
Whiteboard: [orange] → [orange][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/dc4abc6cf76d
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 16
Whiteboard: [orange][fixed-in-fx-team] → [orange]
Keywords: intermittent-failure
While looking into the failure from bug 802390 comment 18, I noticed that the commented subtest-numbering was off in this test, dating back to the cset in comment 15 / comment 16.  That test modified the numbering in such a way as to skip 13, so when the harness reports issues in tests #13 #14 and #15, those correspond to the chunks labeled as #14 #15 and #16 in the test file.

Anyway, I just fixed the numbering in the test:
  https://hg.mozilla.org/integration/mozilla-inbound/rev/2cfe4e2ada97
(Assignee)

Comment 18

5 years ago
Thank you Daniel. Yes, numbering was off for quite some time...
https://hg.mozilla.org/mozilla-central/rev/2cfe4e2ada97
Whiteboard: [orange]
You need to log in before you can comment on or make changes to this bug.