760837 - Intermittent browser_webconsole_bug_595934_message_categories.js | expectUncaughtException was called but no uncaught exception was detected!

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Mihai Sucan [:msucan]]

Rev4 MacOSX Lion 10.7 fx-team opt test mochitest-other

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_webconsole_bug_595934_message_categories.js | expectUncaughtException was called but no uncaught exception was detected!

Push:
https://hg.mozilla.org/integration/fx-team/rev/05eeabb5db0a

Brief log:
https://tbpl.mozilla.org/php/getParsedLog.php?id=12311303&tree=Fx-Team

Comment 1

[Mihai Sucan [:msucan]]

Attachment: proposed fix

Comment 2

[Mihai Sucan [:msucan]]

Attachment: [in-fx-team] disable subtest

Comment 3

[Legacy TBPL/Treeherder Robot]

dcamp
https://tbpl.mozilla.org/php/getParsedLog.php?id=12312549&tree=Fx-Team
Rev4 MacOSX Lion 10.7 fx-team opt test mochitest-other on 2012-06-02 11:45:45
slave: talos-r4-lion-011

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_webconsole_bug_595934_message_categories.js | expectUncaughtException was called but no uncaught exception was detected!

Comment 4

[Legacy TBPL/Treeherder Robot]

past
https://tbpl.mozilla.org/php/getParsedLog.php?id=12312549&tree=Fx-Team
Rev4 MacOSX Lion 10.7 fx-team opt test mochitest-other on 2012-06-02 11:45:45
slave: talos-r4-lion-011

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_webconsole_bug_595934_message_categories.js | expectUncaughtException was called but no uncaught exception was detected!

Comment 5

[Legacy TBPL/Treeherder Robot]

msucan
https://tbpl.mozilla.org/php/getParsedLog.php?id=12312549&tree=Fx-Team
Rev4 MacOSX Lion 10.7 fx-team opt test mochitest-other on 2012-06-02 11:45:45
slave: talos-r4-lion-011

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_webconsole_bug_595934_message_categories.js | expectUncaughtException was called but no uncaught exception was detected!

Comment 6

[Legacy TBPL/Treeherder Robot]

past
https://tbpl.mozilla.org/php/getParsedLog.php?id=12312902&tree=Try
Rev4 MacOSX Lion 10.7 try opt test mochitest-other on 2012-06-02 11:54:39
slave: talos-r4-lion-034

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_webconsole_bug_595934_message_categories.js | expectUncaughtException was called but no uncaught exception was detected!

Comment 7

[Legacy TBPL/Treeherder Robot]

msucan
https://tbpl.mozilla.org/php/getParsedLog.php?id=12312911&tree=Fx-Team
Rev3 WINNT 6.1 fx-team opt test mochitest-other on 2012-06-02 11:49:49
slave: talos-r3-w7-017

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_webconsole_bug_595934_message_categories.js | expectUncaughtException was called but no uncaught exception was detected!

Comment 8

[Mihai Sucan [:msucan]]

Comment on attachment 629502 [details] [diff] [review]
[in-fx-team] disable subtest

https://hg.mozilla.org/integration/fx-team/rev/ff4163e5f869

Comment 9

[Dave Camp (:dcamp)]

https://hg.mozilla.org/mozilla-central/rev/ff4163e5f869

I'm leaving this open because Mihai mentioned that he wanted to fix the test for real.  Close if you decide otherwise please Mihai.

Comment 10

[Legacy TBPL/Treeherder Robot]

past
https://tbpl.mozilla.org/php/getParsedLog.php?id=12321882&tree=Try
Rev3 WINNT 6.1 try opt test mochitest-other on 2012-06-02 17:57:18
slave: talos-r3-w7-071

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_webconsole_bug_595934_message_categories.js | expectUncaughtException was called but no uncaught exception was detected!

Comment 11

[Mihai Sucan [:msucan]]

Attachment: test fix - rebased

This is the test fix that I'd like us to land after the aurora merge.

Green runs:
https://tbpl.mozilla.org/?tree=Try&rev=9603af047508

Comment 12

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 629573 [details] [diff] [review]
test fix - rebased

Review of attachment 629573 [details] [diff] [review]:
-----------------------------------------------------------------

Yep, the plan seems solid. I suppose you could move it even further up if we ever get another similar failure.

Comment 13

[Mihai Sucan [:msucan]]

Attachment: [in-fx-team] test fix - improvements

The previous patch had no failures after many runs on the try server, but ultimately I was able to reproduce failures on my machine.

I had to make more changes, this is the patch I ended up with. No more failures on my machine.

Try push looks green again:
https://tbpl.mozilla.org/?tree=Try&rev=665e11e32550

Comment 14

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 632795 [details] [diff] [review]
[in-fx-team] test fix - improvements

Review of attachment 632795 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/webconsole/test/browser_webconsole_bug_595934_message_categories.js
@@ +159,5 @@
> +      },
> +      successFn: testNext,
> +      failureFn: function() {
> +        info("foundCategory " + foundCategory + " foundText " + foundText +
> +             "pageLoaded " + pageLoaded + " pageError " + pageError);

You probably want a space before pageLoaded inside the string literal.

Comment 15

[Mihai Sucan [:msucan]]

Comment on attachment 632795 [details] [diff] [review]
[in-fx-team] test fix - improvements

https://hg.mozilla.org/integration/fx-team/rev/dc4abc6cf76d

Thank you Panos. I fixed that in the patch I landed.

Comment 16

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/dc4abc6cf76d

Comment 17

[Daniel Holbert [:dholbert]]

While looking into the failure from bug 802390 comment 18, I noticed that the commented subtest-numbering was off in this test, dating back to the cset in comment 15 / comment 16.  That test modified the numbering in such a way as to skip 13, so when the harness reports issues in tests #13 #14 and #15, those correspond to the chunks labeled as #14 #15 and #16 in the test file.

Anyway, I just fixed the numbering in the test:
  https://hg.mozilla.org/integration/mozilla-inbound/rev/2cfe4e2ada97

Comment 18

[Mihai Sucan [:msucan]]

Thank you Daniel. Yes, numbering was off for quite some time...

Comment 19

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/2cfe4e2ada97