The default bug view has changed. See this FAQ.

decomtaminate Get Row / Column Description() on accessible tables

RESOLVED FIXED in mozilla16

Status

()

Core
Disability Access APIs
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: tbsaunde, Assigned: capella)

Tracking

unspecified
mozilla16
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor=trev.saunders@gmail.com][lang=c++])

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
follow same approach as bug 757504
(Assignee)

Updated

5 years ago
Assignee: nobody → markcapella
Status: NEW → ASSIGNED
(Assignee)

Updated

5 years ago
Depends on: 760880
(Assignee)

Comment 1

5 years ago
Created attachment 632961 [details] [diff] [review]
Patch (v1)
Attachment #632961 - Flags: review?(trev.saunders)
(Reporter)

Comment 2

5 years ago
Comment on attachment 632961 [details] [diff] [review]
Patch (v1)

>+xpcAccessibleTable::GetColumnDescription(PRInt32 aColIdx, nsAString& aDescription)

nit, over 80 chars

>+XULTreeGridAccessible::ColDescription(PRUint32 aColIdx, nsString& aDescription)
> {
>   aDescription.Truncate();
> 
>-  if (IsDefunct())
>-    return NS_ERROR_FAILURE;
>-
>   nsCOMPtr<nsIAccessible> treeColumns;
>   Accessible::GetFirstChild(getter_AddRefs(treeColumns));
>   if (treeColumns) {
>     nsCOMPtr<nsIAccessible> treeColumnItem;
>-    treeColumns->GetChildAt(aColumnIndex, getter_AddRefs(treeColumnItem));
>+    treeColumns->GetChildAt(aColIdx, getter_AddRefs(treeColumnItem));

mind filing a bug to clean up this silly com stuff?

>   var columnDescription;
>   works = true;
>   try{
>     columnDescription = accTable.getColumnDescription(1);
>   }
>   catch (e) {
>     works = false;
>   }
>-  todo(works, "columnDescription should not throw");
>+  is(works, true, "columnDescription should not throw");

well, instead of  checking works == true you could get rid of the try / catch.  Which would just leave you with the silly test var rowDescription = accTable.getRowDescription(1);
a todo for actually implementing this stuff doesn't seem really useful.

> 
>   var rowDescription;
>   works = true;
>   try {
>     rowDescription = accTable.getRowDescription(1);
>   }
>   catch (e) {
>     works = false;
>   }
>-  todo(works, "rowDescription should not throw");
>+  is(works, true, "rowDescription should not throw");

same

note this will change what we return for IAccessibleTable from e_NOTIMPL to S_FALSe, but that seems fine.
Attachment #632961 - Flags: review?(trev.saunders) → review+
(Assignee)

Comment 3

5 years ago
https://tbpl.mozilla.org/?tree=Try&rev=77f704ba95f8
(Assignee)

Comment 4

5 years ago
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=eb67e4c9f7df
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/eb67e4c9f7df
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.