XBL Bindings appear in the debugger script dropdown if the debugger is open when the page is refreshed

RESOLVED FIXED in Firefox 15

Status

()

Firefox
Developer Tools: Debugger
P2
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jaws, Assigned: past)

Tracking

Trunk
Firefox 16
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(firefox15 fixed)

Details

Attachments

(1 attachment)

STR:
1. Go to https://tbpl.mozilla.org/?tree=Mozilla-Inbound
2. Open Debugger using the Tools menu
3. Make a note of what the currently selected script file is.
4. Refresh the page, keeping the Debugger open
5. Notice that the currently selected script is now 'resizer.xml'.

Somehow our XBL bindings are leaking to the Debugger when the page refreshes.
Created attachment 630110 [details] [diff] [review]
Patch

The patch in bug 739995 left out the case of newScript notifications, which this patch now fixes.
Assignee: nobody → past
Status: NEW → ASSIGNED
Attachment #630110 - Flags: review?(rcampbell)
Attachment #630110 - Flags: review?(rcampbell) → review+
https://hg.mozilla.org/integration/fx-team/rev/7305a888bb30
Priority: -- → P2
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/7305a888bb30
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 16
Comment on attachment 630110 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): new feature
User impact if declined: we might show some funky-looking scripts in the drop-down if we don't take this.
Testing completed (on m-c, etc.): on m-c 
Risk to taking this patch (and alternatives if risky): pretty minimal. Better checking of chrome uris in script urls.
String or UUID changes made by this patch: none.
Attachment #630110 - Flags: approval-mozilla-aurora?
tracking-firefox15: --- → ?

Updated

5 years ago
Attachment #630110 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/3c388f49c936
status-firefox15: --- → fixed
tracking-firefox15: ? → ---
You need to log in before you can comment on or make changes to this bug.