760882 - XBL Bindings appear in the debugger script dropdown if the debugger is open when the page is refreshed

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Jared Wein [:jaws] (please needinfo? me)]

STR:
1. Go to https://tbpl.mozilla.org/?tree=Mozilla-Inbound
2. Open Debugger using the Tools menu
3. Make a note of what the currently selected script file is.
4. Refresh the page, keeping the Debugger open
5. Notice that the currently selected script is now 'resizer.xml'.

Somehow our XBL bindings are leaking to the Debugger when the page refreshes.

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Patch

The patch in bug 739995 left out the case of newScript notifications, which this patch now fixes.

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/7305a888bb30

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/7305a888bb30

Comment 4

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 630110 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): new feature
User impact if declined: we might show some funky-looking scripts in the drop-down if we don't take this.
Testing completed (on m-c, etc.): on m-c 
Risk to taking this patch (and alternatives if risky): pretty minimal. Better checking of chrome uris in script urls.
String or UUID changes made by this patch: none.

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/3c388f49c936