Closed Bug 760896 Opened 12 years ago Closed 12 years ago

Use CommonUtils.json* in AitC Storage module

Categories

(Web Apps Graveyard :: AppsInTheCloud, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: anant, Assigned: anant)

Details

(Whiteboard: [blocking-aitc+][qa-])

Attachments

(1 file)

The Storage modules have manual routines to save and load JSON from/to disk, while bug 760448 added error reporting to CommonUtils.jsonLoad. We should move to using that instead.
Whiteboard: [blocking-aitc-]
Though it was decided this wasn't a blocker at the last triage meeting, bug 748977 is a blocker, and I think the easiest way to solve that bug is by fixing this one. 2 birds with 1 stone, so marking as blocker.
Whiteboard: [blocking-aitc-] → [blocking-aitc+]
(In reply to Anant Narayanan [:anant] from comment #1)
> Though it was decided this wasn't a blocker at the last triage meeting, bug
> 748977 is a blocker, and I think the easiest way to solve that bug is by
> fixing this one. 2 birds with 1 stone, so marking as blocker.

Are you referring to the right bug here? bug 748977 is the bug about front-end firefox UX for the AITC dashboard.
Bah, copy-paste fail. I meant bug 760905.
I have a WIP patch for this, just needs some cleanup and tweaks to tests so they pass again.
Assignee: nobody → anant
My theory is that this will make bug 760905 go away. A theory that I'm testing at https://tbpl.mozilla.org/?tree=Try&rev=7c32bb38a471...
Attachment #638456 - Flags: review?(gps)
Status: NEW → ASSIGNED
OS: Linux → All
Hardware: x86 → All
Comment on attachment 638456 [details] [diff] [review]
User CommonUtils.json* for storage queue

Review of attachment 638456 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Yay, less lines of source \o/
Attachment #638456 - Flags: review?(gps) → review+
https://hg.mozilla.org/services/services-central/rev/5099eb0d0287
Whiteboard: [blocking-aitc+] → [blocking-aitc+], [fixed in services]
Is there anything to verify here from an end-user perspective?
Whiteboard: [blocking-aitc+], [fixed in services] → [blocking-aitc+], [fixed in services], [qa?]
(In reply to Jason Smith [:jsmith] from comment #8)
> Is there anything to verify here from an end-user perspective?

Nope!
Whiteboard: [blocking-aitc+], [fixed in services], [qa?] → [blocking-aitc+], [fixed in services], [qa-]
https://hg.mozilla.org/mozilla-central/rev/5099eb0d0287
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [blocking-aitc+], [fixed in services], [qa-] → [blocking-aitc+][qa-]
Product: Web Apps → Web Apps Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: