Closed Bug 760902 Opened 9 years ago Closed 3 years ago

More comprehensive tests are needed for AITC

Categories

(Web Apps Graveyard :: AppsInTheCloud, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: anant, Assigned: anant)

References

Details

(Whiteboard: [blocking-aitc-])

Attachments

(1 file)

Some modules already have tests, but before AITC is enabled, we need a few more.

REST client tests are over in bug 750948 (which may need a few more as well), but in addition to those we'll need:

- Additional tests cases for storage.js, specifically for the registry
- Tests for manager.js:
-- Token refresh tests
-- GET/PUT timer tests
-- Browser chrome tests for marketplace/dashboard tab open/close behavior

The timer tests are likely to need a bit more work as we'll need special hooks to let tests speed them up to stay within test timeout limits.
Whiteboard: [blocking-aitc]
Whiteboard: [blocking-aitc] → [blocking-aitc+]
We probably need a mochitest to see if a client created when the user visits the dashboard.
Another case (this one might be harder to solve): does Aitc.js create an instance of Aitc correctly when dom.mozApps.used changes from false to true?
OS: Linux → All
Hardware: x86 → All
The token refresh tests are covered in the tests from bug 760910.
There's not that many more tests we can actually check-in. The tab open close behavior and client creation checks rely on external servers so they are not suitable for checking in. The token refresh tests were already written up.
Assignee: nobody → anant
Status: NEW → ASSIGNED
Attachment #642145 - Flags: review?(gps)
Comment on attachment 642145 [details] [diff] [review]
Add GET timer test

Review of attachment 642145 [details] [diff] [review]:
-----------------------------------------------------------------

I worry about the accuracy of timers on build hosts. I think there is a higher-than-normal chance this could intermittent orange. I guess we'll deal with it if we see it.
Attachment #642145 - Flags: review?(gps) → review+
https://hg.mozilla.org/services/services-central/rev/66a9982a4bc9
Whiteboard: [blocking-aitc+] → [blocking-aitc+], [fixed in services]
Whiteboard: [blocking-aitc+], [fixed in services] → [blocking-aitc+], [fixed in services], [qa-]
(In reply to Gregory Szorc [:gps] from comment #5)
> Comment on attachment 642145 [details] [diff] [review]
> Add GET timer test
> 
> Review of attachment 642145 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I worry about the accuracy of timers on build hosts. I think there is a
> higher-than-normal chance this could intermittent orange. I guess we'll deal
> with it if we see it.

And we have our first orange:

https://tbpl.mozilla.org/php/getParsedLog.php?id=13517119&tree=Services-Central&full=1

I'm inclined to back this out until we have something more reliable. I'm not sure what kind of variance we'll need in the timers to accomplish that. I have a feeling the proper answer will be "don't rely on timers."
Backed out after receiving a few more oranges:

https://hg.mozilla.org/services/services-central/rev/d9d878d5b8a7

Per discussions with Anant earlier in the day, I don't believe this should block AITC launch. It's just a test after all. We should continue to strive for better test coverage in mozilla-central.
Whiteboard: [blocking-aitc+], [fixed in services], [qa-]
Whiteboard: [blocking-aitc-]
Dead component, closing bugs in it.
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → WONTFIX
Product: Web Apps → Web Apps Graveyard
You need to log in before you can comment on or make changes to this bug.