Last Comment Bug 761019 - gfx/harfbuzz/src/hb-ot-shape-complex-indic.cc:620: error: comma at end of enumerator list
: gfx/harfbuzz/src/hb-ot-shape-complex-indic.cc:620: error: comma at end of enu...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics: Text (show other bugs)
: Trunk
: Other OpenBSD
: -- normal (vote)
: mozilla15
Assigned To: Landry Breuil (:gaston)
:
Mentors:
Depends on: 758236
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-03 12:57 PDT by Landry Breuil (:gaston)
Modified: 2012-06-04 09:38 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Remove extra comma (928 bytes, patch)
2012-06-03 13:00 PDT, Landry Breuil (:gaston)
jd.bugzilla: review+
Details | Diff | Review

Description Landry Breuil (:gaston) 2012-06-03 12:57:18 PDT
See summary, bug #758236 broke my openbsd/4.2.1 builds. See http://buildbot.rhaalovely.net/builders/comm-central-amd64/builds/383/steps/build/logs/stdio

Fixup in a few.
Comment 1 Landry Breuil (:gaston) 2012-06-03 13:00:25 PDT
Created attachment 629640 [details] [diff] [review]
Remove extra comma

Probably fixes the build for me.
Comment 2 John Daggett (:jtd) 2012-06-03 23:39:19 PDT
Pushed to inbound
https://hg.mozilla.org/integration/mozilla-inbound/rev/699ded02ce5a
Comment 3 Jonathan Kew (:jfkthame) 2012-06-04 03:58:34 PDT
Reported upstream.
Comment 4 Landry Breuil (:gaston) 2012-06-04 09:06:52 PDT
http://hg.mozilla.org/mozilla-central/rev/1dc3d837c727
Comment 5 :Ehsan Akhgari (busy, don't ask for review please) 2012-06-04 09:31:14 PDT
Also https://hg.mozilla.org/mozilla-central/rev/699ded02ce5a (this seems like it was double landed on both inbound and central).
Comment 6 Landry Breuil (:gaston) 2012-06-04 09:37:20 PDT
(In reply to Ehsan Akhgari [:ehsan] from comment #5)
> Also https://hg.mozilla.org/mozilla-central/rev/699ded02ce5a (this seems
> like it was double landed on both inbound and central).

Yes, sorry my fault, i screwed up here while doing my push for 761123 & 761136.
Comment 7 :Ehsan Akhgari (busy, don't ask for review please) 2012-06-04 09:38:30 PDT
(In reply to Landry Breuil (:gaston) from comment #6)
> (In reply to Ehsan Akhgari [:ehsan] from comment #5)
> > Also https://hg.mozilla.org/mozilla-central/rev/699ded02ce5a (this seems
> > like it was double landed on both inbound and central).
> 
> Yes, sorry my fault, i screwed up here while doing my push for 761123 &
> 761136.

No harm done!  I just mentioned it for future reference.  :-)

Note You need to log in before you can comment on or make changes to this bug.