The default bug view has changed. See this FAQ.

Add nsIDocument::GetDocumentType()

RESOLVED FIXED in mozilla16

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
mozilla16
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 629644 [details] [diff] [review]
Patch v1
Attachment #629644 - Flags: review?(mounir)
Comment on attachment 629644 [details] [diff] [review]
Patch v1

Review of attachment 629644 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/base/src/nsDocument.cpp
@@ +4318,5 @@
> +    if (child->NodeType() == nsIDOMNode::DOCUMENT_TYPE_NODE) {
> +      return child;
> +    }
> +  }
> +  return NULL;

I would prefer |nsnull|. I don't think we chose to move to |NULL|.

@@ +4325,4 @@
>  NS_IMETHODIMP
>  nsDocument::GetDoctype(nsIDOMDocumentType** aDoctype)
>  {
>    NS_ENSURE_ARG_POINTER(aDoctype);

No need for that. Use |MOZ_ASSERT(aDocType)| instead.
Attachment #629644 - Flags: review?(mounir) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/mozilla-central/rev/abf52b9aaf54
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.