761020 - Add nsIDocument::GetDocumentType()

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Comment 1

[Mounir Lamouri (:mounir)]

Comment on attachment 629644 [details] [diff] [review]
Patch v1

Review of attachment 629644 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/base/src/nsDocument.cpp
@@ +4318,5 @@
> +    if (child->NodeType() == nsIDOMNode::DOCUMENT_TYPE_NODE) {
> +      return child;
> +    }
> +  }
> +  return NULL;

I would prefer |nsnull|. I don't think we chose to move to |NULL|.

@@ +4325,4 @@
>  NS_IMETHODIMP
>  nsDocument::GetDoctype(nsIDOMDocumentType** aDoctype)
>  {
>    NS_ENSURE_ARG_POINTER(aDoctype);

No need for that. Use |MOZ_ASSERT(aDocType)| instead.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/abf52b9aaf54