Last Comment Bug 761020 - Add nsIDocument::GetDocumentType()
: Add nsIDocument::GetDocumentType()
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla16
Assigned To: :Ms2ger (⌚ UTC+1/+2)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-03 13:19 PDT by :Ms2ger (⌚ UTC+1/+2)
Modified: 2012-06-06 03:27 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (5.17 KB, patch)
2012-06-03 13:19 PDT, :Ms2ger (⌚ UTC+1/+2)
mounir: review+
Details | Diff | Splinter Review

Description :Ms2ger (⌚ UTC+1/+2) 2012-06-03 13:19:09 PDT
Created attachment 629644 [details] [diff] [review]
Patch v1
Comment 1 Mounir Lamouri (:mounir) 2012-06-04 03:12:09 PDT
Comment on attachment 629644 [details] [diff] [review]
Patch v1

Review of attachment 629644 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/base/src/nsDocument.cpp
@@ +4318,5 @@
> +    if (child->NodeType() == nsIDOMNode::DOCUMENT_TYPE_NODE) {
> +      return child;
> +    }
> +  }
> +  return NULL;

I would prefer |nsnull|. I don't think we chose to move to |NULL|.

@@ +4325,4 @@
>  NS_IMETHODIMP
>  nsDocument::GetDoctype(nsIDOMDocumentType** aDoctype)
>  {
>    NS_ENSURE_ARG_POINTER(aDoctype);

No need for that. Use |MOZ_ASSERT(aDocType)| instead.
Comment 2 :Ms2ger (⌚ UTC+1/+2) 2012-06-06 03:27:55 PDT
https://hg.mozilla.org/mozilla-central/rev/abf52b9aaf54

Note You need to log in before you can comment on or make changes to this bug.