User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/15.0 Firefox/15.0a1 Build ID: 20120602202922
Created attachment 629660 [details] [diff] [review] Patch to fix gstreamer-related crash
HTML 5 video crashes when gstreamer is enabled (--enable-gstreamer) since the fix for bug 714408 was checked in. VideoData::Create() in content/media/nsBuiltinDecoderReader.cpp changed from calling PlanarYCbCrImage::SetData() to PlanarYCbCrImage::CopyData() from gfx/layers/ImageLayers.cpp. This means that the mOffset and mSkip members of YCbCrBuffer::Plane must now be set correctly. nsGStreamerReader::DecodeVideoFrame() in content/media/gstreamer/nsGStreamerReader.cpp does not initialize either mOffset or mSkip, leading to a crash in CopyPlane() in gfx/layers/ImageLayers.cpp caused by the random values of mOffset and mSkip. The fix is to initialize mOffset and mSkip to 0 in nsGStreamerReader::DecodeVideoFrame().
Comment on attachment 629660 [details] [diff] [review] Patch to fix gstreamer-related crash Thanks!
5 years ago
(This didn't make it in time for 15).