761030 - Crash with HTML 5 video with gstreamer enabled

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Stephen Moehle]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/15.0 Firefox/15.0a1
Build ID: 20120602202922

Comment 1

[Stephen Moehle]

Attachment: Patch to fix gstreamer-related crash

Comment 2

[Stephen Moehle]

HTML 5 video crashes when gstreamer is enabled (--enable-gstreamer) since the fix for bug 714408 was checked in.

VideoData::Create() in content/media/nsBuiltinDecoderReader.cpp changed from calling PlanarYCbCrImage::SetData() to PlanarYCbCrImage::CopyData() from gfx/layers/ImageLayers.cpp. This means that the mOffset and mSkip members of YCbCrBuffer::Plane must now be set correctly.

nsGStreamerReader::DecodeVideoFrame() in content/media/gstreamer/nsGStreamerReader.cpp does not initialize either mOffset or mSkip, leading to a crash in CopyPlane() in gfx/layers/ImageLayers.cpp caused by the random values of mOffset and mSkip.

The fix is to initialize mOffset and mSkip to 0 in nsGStreamerReader::DecodeVideoFrame().

Comment 3

[Matthew Gregan [:kinetik]]

Comment on attachment 629660 [details] [diff] [review]
Patch to fix gstreamer-related crash

Thanks!

Comment 5

[cajbir (:cajbir)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b8c6c7c773c3

Comment 6

[Ed Morley [:emorley]]

(This didn't make it in time for 15).

Comment 7

[Geoff Lankow (:darktrojan)]

https://hg.mozilla.org/mozilla-central/rev/b8c6c7c773c3