Last Comment Bug 761030 - Crash with HTML 5 video with gstreamer enabled
: Crash with HTML 5 video with gstreamer enabled
: crash
Product: Core
Classification: Components
Component: Audio/Video (show other bugs)
: Trunk
: x86_64 Linux
: -- critical (vote)
: mozilla16
Assigned To: Stephen Moehle
: Maire Reavy [:mreavy]
: 761409 (view as bug list)
Depends on:
  Show dependency treegraph
Reported: 2012-06-03 14:41 PDT by Stephen Moehle
Modified: 2012-06-05 06:19 PDT (History)
4 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Patch to fix gstreamer-related crash (1012 bytes, patch)
2012-06-03 14:58 PDT, Stephen Moehle
kinetik: review+
Details | Diff | Splinter Review

Description Stephen Moehle 2012-06-03 14:41:57 PDT
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/15.0 Firefox/15.0a1
Build ID: 20120602202922
Comment 1 Stephen Moehle 2012-06-03 14:58:03 PDT
Created attachment 629660 [details] [diff] [review]
Patch to fix gstreamer-related crash
Comment 2 Stephen Moehle 2012-06-03 15:01:20 PDT
HTML 5 video crashes when gstreamer is enabled (--enable-gstreamer) since the fix for bug 714408 was checked in.

VideoData::Create() in content/media/nsBuiltinDecoderReader.cpp changed from calling PlanarYCbCrImage::SetData() to PlanarYCbCrImage::CopyData() from gfx/layers/ImageLayers.cpp. This means that the mOffset and mSkip members of YCbCrBuffer::Plane must now be set correctly.

nsGStreamerReader::DecodeVideoFrame() in content/media/gstreamer/nsGStreamerReader.cpp does not initialize either mOffset or mSkip, leading to a crash in CopyPlane() in gfx/layers/ImageLayers.cpp caused by the random values of mOffset and mSkip.

The fix is to initialize mOffset and mSkip to 0 in nsGStreamerReader::DecodeVideoFrame().
Comment 3 Matthew Gregan [:kinetik] 2012-06-03 17:17:34 PDT
Comment on attachment 629660 [details] [diff] [review]
Patch to fix gstreamer-related crash

Comment 4 Paul Adenot (:padenot) 2012-06-04 16:21:31 PDT
*** Bug 761409 has been marked as a duplicate of this bug. ***
Comment 6 Ed Morley [:emorley] 2012-06-05 06:15:02 PDT
(This didn't make it in time for 15).
Comment 7 Geoff Lankow (:darktrojan) 2012-06-05 06:19:03 PDT

Note You need to log in before you can comment on or make changes to this bug.