761135 - Remove XPCOMGlueShutdown

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Benjamin Smedberg]

XPCOMGlueShutdown is a footgun: there's absolutely no need to unload the XPCOM libraries (we couldn't reload a new version anyway), and if there happened to be any extra threads running that late they would very likely crash. It should be removed.

Comment 1

[Mike Hommey [:glandium]]

I wonder if that couldn't lead to leaks being reported in debug builds.

So I pushed a simple test to try.
https://tbpl.mozilla.org/?tree=Try&rev=2dfe5fcb157f

Comment 2

[Mike Hommey [:glandium]]

(In reply to Mike Hommey [:glandium] from comment #1)
> I wonder if that couldn't lead to leaks being reported in debug builds.
> 
> So I pushed a simple test to try.
> https://tbpl.mozilla.org/?tree=Try&rev=2dfe5fcb157f

Apparently, it's fine.

Comment 3

[Benoit Girard (:BenWa)]

This is getting in the way of shutdown write poisoning. I'll take this.

Comment 4

[Benoit Girard (:BenWa)]

https://tbpl.mozilla.org/?tree=Try&rev=ea07ea295b4b

Comment 5

[Benoit Girard (:BenWa)]

Attachment: patch

Note that I did NOT remove XPCOMGlueUnload which is still called from a few other locations

Comment 6

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/03fd5f43435d

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/03fd5f43435d

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/03fd5f43435d

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/03fd5f43435d

Comment 10

[Joshua Cranmer [:jcranmer]]

Bustage fix for comm-central pushed:
https://hg.mozilla.org/comm-central/rev/963d7a2dfe81

Comment 11

[Benoit Girard (:BenWa)]

Thanks jcranmer