Closed Bug 761135 Opened 7 years ago Closed 7 years ago
XPCOMGlueShutdown is a footgun: there's absolutely no need to unload the XPCOM libraries (we couldn't reload a new version anyway), and if there happened to be any extra threads running that late they would very likely crash. It should be removed.
I wonder if that couldn't lead to leaks being reported in debug builds. So I pushed a simple test to try. https://tbpl.mozilla.org/?tree=Try&rev=2dfe5fcb157f
(In reply to Mike Hommey [:glandium] from comment #1) > I wonder if that couldn't lead to leaks being reported in debug builds. > > So I pushed a simple test to try. > https://tbpl.mozilla.org/?tree=Try&rev=2dfe5fcb157f Apparently, it's fine.
This is getting in the way of shutdown write poisoning. I'll take this.
Assignee: benjamin → bgirard
Note that I did NOT remove XPCOMGlueUnload which is still called from a few other locations
Attachment #698841 - Flags: review?(benjamin) → review+
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
Bustage fix for comm-central pushed: https://hg.mozilla.org/comm-central/rev/963d7a2dfe81
You need to log in before you can comment on or make changes to this bug.