Last Comment Bug 761136 - Invalid uses of uint64_t vs PRUint64 in IndexedDBParent.cpp after bug 666693
: Invalid uses of uint64_t vs PRUint64 in IndexedDBParent.cpp after bug 666693
Status: RESOLVED FIXED
: regression
Product: Core
Classification: Components
Component: DOM: IndexedDB (show other bugs)
: Trunk
: Other OpenBSD
: -- blocker (vote)
: mozilla15
Assigned To: Landry Breuil (:gaston)
:
Mentors:
Depends on:
Blocks: 666693
  Show dependency treegraph
 
Reported: 2012-06-04 06:38 PDT by Landry Breuil (:gaston)
Modified: 2012-06-05 08:35 PDT (History)
1 user (show)
bugzillamozillaorg_serge_20140323: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
GetOldVersion expects a PRUint64 (2.64 KB, patch)
2012-06-04 06:42 PDT, Landry Breuil (:gaston)
bent.mozilla: review+
Details | Diff | Splinter Review

Description Landry Breuil (:gaston) 2012-06-04 06:38:56 PDT
GetOldVersion expects a PRUint64..


/home/landry/src/mozilla-central/dom/indexedDB/ipc/IndexedDBParent.cpp: In member function 'nsresult mozilla::dom::indexedDB::IndexedDBDatabaseParent::HandleRequestEvent(nsIDOMEvent*, const nsAString_internal&)':
/home/landry/src/mozilla-central/dom/indexedDB/ipc/IndexedDBParent.cpp:243: error: invalid conversion from 'uint64_t*' to 'PRUint64*'
/home/landry/src/mozilla-central/dom/indexedDB/ipc/IndexedDBParent.cpp:243: error:   initializing argument 1 of 'virtual nsresult nsIIDBVersionChangeEvent::GetOldVersion(PRUint64*)'
/home/landry/src/mozilla-central/dom/indexedDB/ipc/IndexedDBParent.cpp:337: error: invalid conversion from 'uint64_t*' to 'PRUint64*'
/home/landry/src/mozilla-central/dom/indexedDB/ipc/IndexedDBParent.cpp:337: error:   initializing argument 1 of 'virtual nsresult nsIIDBVersionChangeEvent::GetOldVersion(PRUint64*)'
/home/landry/src/mozilla-central/dom/indexedDB/ipc/IndexedDBParent.cpp: In member function 'nsresult mozilla::dom::indexedDB::IndexedDBDatabaseParent::HandleDatabaseEvent(nsIDOMEvent*, const nsAString_internal&)':
/home/landry/src/mozilla-central/dom/indexedDB/ipc/IndexedDBParent.cpp:387: error: invalid conversion from 'uint64_t*' to 'PRUint64*'
/home/landry/src/mozilla-central/dom/indexedDB/ipc/IndexedDBParent.cpp:387: error:   initializing argument 1 of 'virtual nsresult nsIIDBVersionChangeEvent::GetOldVersion(PRUint64*)'
/home/landry/src/mozilla-central/dom/indexedDB/ipc/IndexedDBParent.cpp: In member function 'virtual bool mozilla::dom::indexedDB::IndexedDBDatabaseParent::RecvPIndexedDBTransactionConstructor(mozilla::dom::indexedDB::PIndexedDBTransactionParent*, const mozilla::dom::indexedDB
::ipc::TransactionParams&)':
/home/landry/src/mozilla-central/dom/indexedDB/ipc/IndexedDBParent.cpp:447: warning: unused variable 'names'
/home/landry/src/mozilla-central/dom/indexedDB/ipc/IndexedDBParent.cpp:448: warning: unused variable 'mode'
/home/landry/src/mozilla-central/dom/indexedDB/ipc/IndexedDBParent.cpp: In member function 'nsresult mozilla::dom::indexedDB::IndexedDBDeleteDatabaseRequestParent::HandleEvent(nsIDOMEvent*)':
/home/landry/src/mozilla-central/dom/indexedDB/ipc/IndexedDBParent.cpp:1761: error: invalid conversion from 'uint64_t*' to 'PRUint64*'
/home/landry/src/mozilla-central/dom/indexedDB/ipc/IndexedDBParent.cpp:1761: error:   initializing argument 1 of 'virtual nsresult nsIIDBVersionChangeEvent::GetOldVersion(PRUint64*)'

Obvious fix would be to declare oldVersion as PRUint64, but maybe we want to keep uint64_t and cast it to PRUint64 in the call ?
Comment 1 Landry Breuil (:gaston) 2012-06-04 06:42:48 PDT
Created attachment 629756 [details] [diff] [review]
GetOldVersion expects a PRUint64

First alternative patch, build now seems to go past IndexdedDBParent.cpp
Comment 2 Landry Breuil (:gaston) 2012-06-04 09:09:23 PDT
http://hg.mozilla.org/mozilla-central/rev/16ba1a04c74d

Note You need to log in before you can comment on or make changes to this bug.