Closed Bug 761136 Opened 12 years ago Closed 12 years ago

Invalid uses of uint64_t vs PRUint64 in IndexedDBParent.cpp after bug 666693

Categories

(Core :: Storage: IndexedDB, defect)

Product:
Core
Component:
Storage: IndexedDB
Platform:
Other
OpenBSD
Type:
defect
Priority:
Not set
Severity:
blocker

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla15

People

(Reporter: gaston, Assigned: gaston)

References

Details

(Keywords: regression)

Attachments

(1 file)

GetOldVersion expects a PRUint64
2.64 KB, patch
bent.mozilla
: review+
Details | Diff | Splinter Review 
GetOldVersion expects a PRUint64..


/home/landry/src/mozilla-central/dom/indexedDB/ipc/IndexedDBParent.cpp: In member function 'nsresult mozilla::dom::indexedDB::IndexedDBDatabaseParent::HandleRequestEvent(nsIDOMEvent*, const nsAString_internal&)':
/home/landry/src/mozilla-central/dom/indexedDB/ipc/IndexedDBParent.cpp:243: error: invalid conversion from 'uint64_t*' to 'PRUint64*'
/home/landry/src/mozilla-central/dom/indexedDB/ipc/IndexedDBParent.cpp:243: error:   initializing argument 1 of 'virtual nsresult nsIIDBVersionChangeEvent::GetOldVersion(PRUint64*)'
/home/landry/src/mozilla-central/dom/indexedDB/ipc/IndexedDBParent.cpp:337: error: invalid conversion from 'uint64_t*' to 'PRUint64*'
/home/landry/src/mozilla-central/dom/indexedDB/ipc/IndexedDBParent.cpp:337: error:   initializing argument 1 of 'virtual nsresult nsIIDBVersionChangeEvent::GetOldVersion(PRUint64*)'
/home/landry/src/mozilla-central/dom/indexedDB/ipc/IndexedDBParent.cpp: In member function 'nsresult mozilla::dom::indexedDB::IndexedDBDatabaseParent::HandleDatabaseEvent(nsIDOMEvent*, const nsAString_internal&)':
/home/landry/src/mozilla-central/dom/indexedDB/ipc/IndexedDBParent.cpp:387: error: invalid conversion from 'uint64_t*' to 'PRUint64*'
/home/landry/src/mozilla-central/dom/indexedDB/ipc/IndexedDBParent.cpp:387: error:   initializing argument 1 of 'virtual nsresult nsIIDBVersionChangeEvent::GetOldVersion(PRUint64*)'
/home/landry/src/mozilla-central/dom/indexedDB/ipc/IndexedDBParent.cpp: In member function 'virtual bool mozilla::dom::indexedDB::IndexedDBDatabaseParent::RecvPIndexedDBTransactionConstructor(mozilla::dom::indexedDB::PIndexedDBTransactionParent*, const mozilla::dom::indexedDB
::ipc::TransactionParams&)':
/home/landry/src/mozilla-central/dom/indexedDB/ipc/IndexedDBParent.cpp:447: warning: unused variable 'names'
/home/landry/src/mozilla-central/dom/indexedDB/ipc/IndexedDBParent.cpp:448: warning: unused variable 'mode'
/home/landry/src/mozilla-central/dom/indexedDB/ipc/IndexedDBParent.cpp: In member function 'nsresult mozilla::dom::indexedDB::IndexedDBDeleteDatabaseRequestParent::HandleEvent(nsIDOMEvent*)':
/home/landry/src/mozilla-central/dom/indexedDB/ipc/IndexedDBParent.cpp:1761: error: invalid conversion from 'uint64_t*' to 'PRUint64*'
/home/landry/src/mozilla-central/dom/indexedDB/ipc/IndexedDBParent.cpp:1761: error:   initializing argument 1 of 'virtual nsresult nsIIDBVersionChangeEvent::GetOldVersion(PRUint64*)'

Obvious fix would be to declare oldVersion as PRUint64, but maybe we want to keep uint64_t and cast it to PRUint64 in the call ?
Depends on: 666693
First alternative patch, build now seems to go past IndexdedDBParent.cpp
Assignee: nobody → landry
Attachment #629756 - Flags: review?(bent.mozilla)
Attachment #629756 - Flags: review?(bent.mozilla) → review+
http://hg.mozilla.org/mozilla-central/rev/16ba1a04c74d
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Blocks: 666693
Severity: normal → blocker
No longer depends on: 666693
Flags: in-testsuite-
Keywords: regression
Target Milestone: --- → mozilla15
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: