761152 - Empty referer after history.pushState

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Michael Valushko]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20100101 Firefox/12.0
Build ID: 20120420145725

Steps to reproduce:

1. Go to https://github.com/balupton to create referer
1. Go to https://github.com/balupton/history.js
2. Enable HTTP requests log
3. Go to 'demo' folder in list. There history.pushState work.
4. Press F5 to refresh page


Actual results:

Page 'https://github.com/balupton/history.js/tree/master/demo' refreshed. Field 'Referer' wasn't set in sent request headers.


Expected results:

Field 'Referer' should contain page address 'https://github.com/balupton' which is referer for current page.
This is work in Chrome.

Comment 1

[Nickolay_Ponomarev]

I can reproduce on current nightly on OS X. See also bug 968861, but not marking as a duplicate, since this is focussed on pushState, while the at least part of the discussion in the other bug seems to be about hash changes.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Yeah, this is the same code internally...

Comment 3

[Malte Jürgens [:maltejur]]

Attachment: Bug 761152 - Copy referrer info to new session history entry on history.pushState r?freddyb!

Per spec [1], we should copy over the complete document state [2], which
includes the referrer info. Bug 1773192 has already added this for the
"replace" case when the session history is in parent (almost always the case),
but it is still missing for the "push" case, and the "replace" case when the
session history is not in parent.

[1] https://html.spec.whatwg.org/multipage/browsing-the-web.html#url-and-history-update-steps
[2] https://html.spec.whatwg.org/multipage/browsing-the-web.html#document-state

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d72a439b6669
Copy referrer info to new session history entry on history.pushState r=freddyb

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/d72a439b6669