Last Comment Bug 761201 - [Skia] Drawing an RGB565 bitmap to another RGB565 bitmap is slow
: [Skia] Drawing an RGB565 bitmap to another RGB565 bitmap is slow
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: unspecified
: x86_64 Linux
: -- normal (vote)
: mozilla16
Assigned To: George Wright (:gw280) (:gwright)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-04 09:55 PDT by George Wright (:gw280) (:gwright)
Modified: 2012-06-05 06:15 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Trigger Skia's RGB565 blitter fast path by using SrcOver instead of Src. (1.42 KB, patch)
2012-06-04 09:55 PDT, George Wright (:gw280) (:gwright)
jmuizelaar: review+
Details | Diff | Review

Description George Wright (:gw280) (:gwright) 2012-06-04 09:55:31 PDT
We fail to trigger a fast path in Skia if we draw from RGB565 to RGB565 with kSrc_Mode set for the xfermode. If we use kSrcOver_Mode it does trigger the fast path, and these two xfermodes are identical on RGB565 as it's opaque.

Filed bug upstream at http://code.google.com/p/skia/issues/detail?id=628
Comment 1 George Wright (:gw280) (:gwright) 2012-06-04 09:55:57 PDT
Created attachment 629831 [details] [diff] [review]
Trigger Skia's RGB565 blitter fast path by using SrcOver instead of Src.
Comment 2 George Wright (:gw280) (:gwright) 2012-06-04 12:33:04 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/2ab6d4d55988
Comment 3 Geoff Lankow (:darktrojan) 2012-06-05 06:15:43 PDT
https://hg.mozilla.org/mozilla-central/rev/2ab6d4d55988

Note You need to log in before you can comment on or make changes to this bug.