Last Comment Bug 761218 - Get rid of the bogus $(DIST)/include/nsprpub include path
: Get rid of the bogus $(DIST)/include/nsprpub include path
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla16
Assigned To: Jonathan Watt [:jwatt] (catching up after vacation)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-04 10:12 PDT by Jonathan Watt [:jwatt] (catching up after vacation)
Modified: 2012-06-09 19:44 PDT (History)
3 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (1.37 KB, patch)
2012-06-04 10:12 PDT, Jonathan Watt [:jwatt] (catching up after vacation)
no flags Details | Diff | Splinter Review
patch (1.64 KB, patch)
2012-06-04 12:18 PDT, Jonathan Watt [:jwatt] (catching up after vacation)
benjamin: review+
Details | Diff | Splinter Review

Description Jonathan Watt [:jwatt] (catching up after vacation) 2012-06-04 10:12:04 PDT
Created attachment 629836 [details] [diff] [review]
patch

We add $(DIST)/include/nsprpub as an include path for everything, but this path doesn't actually exist.
Comment 1 Jonathan Watt [:jwatt] (catching up after vacation) 2012-06-04 10:13:18 PDT
Maybe I should also be removing if from the lines following the touched lines too?
Comment 2 Mike Hommey [:glandium] 2012-06-04 10:16:25 PDT
(In reply to Jonathan Watt [:jwatt] from comment #1)
> Maybe I should also be removing if from the lines following the touched
> lines too?

Yes, please.
Comment 3 Jonathan Watt [:jwatt] (catching up after vacation) 2012-06-04 12:18:59 PDT
Created attachment 629874 [details] [diff] [review]
patch
Comment 4 Ryan VanderMeulen [:RyanVM] 2012-06-09 11:26:32 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/d598ff78094a
Comment 5 Ryan VanderMeulen [:RyanVM] 2012-06-09 19:44:03 PDT
https://hg.mozilla.org/mozilla-central/rev/d598ff78094a

Note You need to log in before you can comment on or make changes to this bug.