Font for the Debugger panels should be message-box

RESOLVED FIXED in Firefox 15

Status

()

Firefox
Developer Tools: Debugger
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jaws, Assigned: past)

Tracking

Trunk
Firefox 16
Points:
---

Firefox Tracking Flags

(firefox15 verified)

Details

Attachments

(1 attachment, 1 obsolete attachment)

I've noticed that the font for the various panels within the Debugger is list-box, which looks pretty ugly on Windows and feels Windows 3.1-ish.

If we switch to font:message-box we'll get Segoe UI on Windows and the respective UI fonts for the other platforms as well.
Created attachment 630115 [details] [diff] [review]
Patch

This should do it.
Assignee: nobody → past
Status: NEW → ASSIGNED
Attachment #630115 - Flags: review?(rcampbell)
Shouldn't this be message-box by default? What happens if you just remove font: -moz-list;?
Created attachment 630156 [details] [diff] [review]
Patch v2

(In reply to Dão Gottwald [:dao] from comment #2)
> Shouldn't this be message-box by default? What happens if you just remove
> font: -moz-list;?

Good point, it looks identical. We probably used to require them when the UI was in HTML.
Attachment #630115 - Attachment is obsolete: true
Attachment #630115 - Flags: review?(rcampbell)
Attachment #630156 - Flags: review?(rcampbell)

Updated

5 years ago
Attachment #630156 - Flags: review?(rcampbell) → review+
Whiteboard: [land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/233a5180da19
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/233a5180da19
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 16
Comment on attachment 630156 [details] [diff] [review]
Patch v2

[Approval Request Comment]
Bug caused by (feature/regressing bug #): New feature.
User impact if declined: Fonts may look funny.
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): Style only.
String or UUID changes made by this patch:
Attachment #630156 - Flags: approval-mozilla-aurora?
tracking-firefox15: --- → ?

Updated

5 years ago
Attachment #630156 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/d2222d108e06
status-firefox15: --- → fixed
tracking-firefox15: ? → ---

Comment 8

5 years ago
Verified as fixed on Firefox 15.0 beta 3 (20120731150526).
status-firefox15: fixed → verified
You need to log in before you can comment on or make changes to this bug.