The default bug view has changed. See this FAQ.

GCLI has hard-coded strings (e.g. "Available commands:", "Commands starting with:")

RESOLVED FIXED in Firefox 16

Status

()

Firefox
Developer Tools: Console
P2
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: flod, Assigned: jwalker)

Tracking

unspecified
Firefox 16
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
http://mxr.mozilla.org/mozilla-central/source/browser/devtools/commandline/gcli.jsm#7937

getHeading: function() {
  return args.search == null ?
          'Available Commands:' :
          'Commands starting with \'' + args.search + '\':';
}

Those strings shouldn't be hard-coded.
Priority: -- → P2
Target Milestone: --- → Firefox 16
Created attachment 631879 [details] [diff] [review]
Upload 1

Also fixed; a couple of other strings that I found while looking for similar problems, and an updated 'not found' message.
Assignee: nobody → jwalker
Status: NEW → ASSIGNED
Attachment #631879 - Flags: review?(francesco.lodolo)
Attachment #631879 - Flags: review?(dcamp)
https://github.com/campd/gcli/pull/49
(Reporter)

Comment 3

5 years ago
Comment on attachment 631879 [details] [diff] [review]
Upload 1

Review of attachment 631879 [details] [diff] [review]:
-----------------------------------------------------------------

Strings and l10n comments look good to me (changing from review to approval since I'm not really entitled to do a review ;-))
Attachment #631879 - Flags: review?(francesco.lodolo) → feedback+
(Reporter)

Comment 4

5 years ago
> changing from review to approval

approval -> feedback

Updated

5 years ago
Attachment #631879 - Flags: review?(dcamp) → review+
https://tbpl.mozilla.org/?tree=Try&rev=d8e8d414e602
https://hg.mozilla.org/mozilla-central/rev/0acca26e3763
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.