761268 - GCLI has hard-coded strings (e.g. "Available commands:", "Commands starting with:")

Status: RESOLVED FIXED

(DevTools :: Console, defect, P2)

Description

[Francesco Lodolo [:flod]]

http://mxr.mozilla.org/mozilla-central/source/browser/devtools/commandline/gcli.jsm#7937

getHeading: function() {
  return args.search == null ?
          'Available Commands:' :
          'Commands starting with \'' + args.search + '\':';
}

Those strings shouldn't be hard-coded.

Comment 1

[Joe Walker [:jwalker]]

Attachment: Upload 1

Also fixed; a couple of other strings that I found while looking for similar problems, and an updated 'not found' message.

Comment 2

[Joe Walker [:jwalker]]

https://github.com/campd/gcli/pull/49

Comment 3

[Francesco Lodolo [:flod]]

Comment on attachment 631879 [details] [diff] [review]
Upload 1

Review of attachment 631879 [details] [diff] [review]:
-----------------------------------------------------------------

Strings and l10n comments look good to me (changing from review to approval since I'm not really entitled to do a review ;-))

Comment 4

[Francesco Lodolo [:flod]]

> changing from review to approval

approval -> feedback

Comment 5

[Joe Walker [:jwalker]]

https://tbpl.mozilla.org/?tree=Try&rev=d8e8d414e602

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/0acca26e3763