Remove XHR.onuploadprogress

RESOLVED FIXED in mozilla17

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
2 years ago

People

(Reporter: Ms2ger, Assigned: bz)

Tracking

(Blocks: 1 bug, {addon-compat, dev-doc-complete})

Trunk
mozilla17
addon-compat, dev-doc-complete
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox15-)

Details

Attachments

(1 attachment)

Comment hidden (empty)
Tracking this to make sure we remove again in the next migration (or evaluate needing to apply the patch from 743666)
tracking-firefox15: --- → +
Assigning to bz for now - is there work to be done here now that 15 is on the Beta channel?
Assignee: nobody → bzbarsky
I don't think we need to track this for 15.

Basically, this bug is about removing a nonstandard feature that we've had for a while.  Firefox 14 shipped with a deprecation warning for uses of this feature.  The only question is how long we wait to remove it...

Looking at the addons mxr, I see three uses of onuploadprogress:

 /8482/content/dropioApiClient.js 
 /10550/chrome/content/ajaxUpload.js 
 /14651/chrome/content/ajaxUpload.js 

We should probably at least get those fixed before we remove it.
We can add it to the compatibility validations for whatever version this ships on, so it isn't necessary to wait for these add-ons to be fixed. We will warn them as long as a I know on which version this is happening.
Keywords: addon-compat
Jorge, thanks!

Peter, any objections to removing this in 17?
Fine by me.
Created attachment 644562 [details] [diff] [review]
No more uploadprogress
Attachment #644562 - Flags: review?(jonas)
Whiteboard: [need review]
Comment on attachment 644562 [details] [diff] [review]
No more uploadprogress

Review of attachment 644562 [details] [diff] [review]:
-----------------------------------------------------------------

Yay!
Attachment #644562 - Flags: review?(jonas) → review+
http://hg.mozilla.org/integration/mozilla-inbound/rev/ef14686c31d0
Flags: in-testsuite-
Whiteboard: [need review]
Backed out due to bustage

 https://hg.mozilla.org/integration/mozilla-inbound/rev/ad5866c81a03

see

 https://tbpl.mozilla.org/php/getParsedLog.php?id=13747517&tree=Mozilla-Inbound#error0

for errors
As far as I can tell, this just triggered a rebuild of the generated events stuff somehow and _that_ just failed for whatever reason.  And is continuing to fail even with this patch backed out, since this patch had nothing to do with it to start with...
Relanded as http://hg.mozilla.org/integration/mozilla-inbound/rev/8fe7b1000a26
https://hg.mozilla.org/mozilla-central/rev/8fe7b1000a26
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
(Reporter)

Updated

5 years ago
Keywords: dev-doc-needed
(Reporter)

Updated

5 years ago
Blocks: 437381
untracking for 15 as per comment 3
tracking-firefox15: + → -
Component: DOM: Mozilla Extensions → DOM
Product: Core → Core
Clearing dev-doc-needed since I didn't think any change was needed in the current XHR doc.
Keywords: dev-doc-needed
Apologies for triggering multiple bugmails.

Updated dev doc: https://developer.mozilla.org/en-US/Firefox/Releases/17
Keywords: dev-doc-complete
You need to log in before you can comment on or make changes to this bug.