761299 - Cleanup DeleteRangeTxn::CreateTxnsToDeleteBetween

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Comment 1

[(no longer active)]

Comment on attachment 629903 [details] [diff] [review]
Patch v1

Review of attachment 629903 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/libeditor/base/DeleteRangeTxn.cpp
@@ +268,2 @@
>  
> +    child = child->GetNextSibling();

Please loop on |child|, not the child count.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 629903 [details] [diff] [review]
Patch v1

Review of attachment 629903 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/libeditor/base/DeleteRangeTxn.cpp
@@ +253,5 @@
> +  }
> +
> +  nsCOMPtr<nsINode> startParent = do_QueryInterface(aStartParent);
> +  NS_ENSURE_STATE(startParent);
> +  NS_ASSERTION(aEndOffset <= startParent->Length(), "bad aEndOffset");

This should actually be GetChildCount() (which doesn't make any difference)

Comment 3

[(no longer active)]

Comment on attachment 629903 [details] [diff] [review]
Patch v1

Review of attachment 629903 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/libeditor/base/DeleteRangeTxn.cpp
@@ +253,5 @@
> +  }
> +
> +  nsCOMPtr<nsINode> startParent = do_QueryInterface(aStartParent);
> +  NS_ENSURE_STATE(startParent);
> +  NS_ASSERTION(aEndOffset <= startParent->Length(), "bad aEndOffset");

Right.

@@ +268,2 @@
>  
> +    child = child->GetNextSibling();

NM.

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/42c17eb4789a