Last Comment Bug 761306 - Make nsInsertTagCommand::mTagName an nsIAtom*
: Make nsInsertTagCommand::mTagName an nsIAtom*
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Editor (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla16
Assigned To: :Ms2ger (⌚ UTC+1/+2)
:
: Makoto Kato [:m_kato]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-04 13:45 PDT by :Ms2ger (⌚ UTC+1/+2)
Modified: 2012-06-06 03:29 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (6.58 KB, patch)
2012-06-04 13:45 PDT, :Ms2ger (⌚ UTC+1/+2)
ehsan: review+
Details | Diff | Splinter Review

Description :Ms2ger (⌚ UTC+1/+2) 2012-06-04 13:45:29 PDT
Created attachment 629909 [details] [diff] [review]
Patch v1
Comment 1 :Ehsan Akhgari 2012-06-04 13:56:02 PDT
Comment on attachment 629909 [details] [diff] [review]
Patch v1

Review of attachment 629909 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/composer/src/nsComposerCommands.h
@@ +88,5 @@
>  
>  class nsInsertTagCommand : public nsBaseComposerCommand
>  {
>  public:
> +  nsInsertTagCommand(nsIAtom* aTagName);

Nit: make it explicit please.
Comment 2 :Ms2ger (⌚ UTC+1/+2) 2012-06-06 03:29:35 PDT
https://hg.mozilla.org/mozilla-central/rev/14b0be173b03

Note You need to log in before you can comment on or make changes to this bug.