Closed Bug 761319 Opened 8 years ago Closed 8 years ago

Feed preview is broken in unpackaged build

Categories

(SeaMonkey :: Feed Discovery and Preview, defect)

All
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.13

People

(Reporter: neil, Assigned: neil)

References

Details

Attachments

(2 files, 1 obsolete file)

When it detects a feed, the feed converter redirects the load to about:feeds to actually preview the feed. The feed writer then attempts to verify that it is not being used maliciously by comparing the page's final URI with that obtained by manually resolving the chrome URI that it is expecting to have been loaded.

Unfortunately bug 670514 changed the URI that is returned by the channel in an unpackaged build, so that if you build on Linux and run dist/bin/seamonkey then the test fails and the feed preview does not appear.
Attached patch Proposed patchSplinter Review
This fixes the problem by mirroring the way the feed preview page URL gets resolved. I was also able to use the friendly "about:feeds" URL thus conveniently also avoiding duplicating knowledge from the about module.

Gavin, is this something you would want ported to Firefox? You seem to have fortuitously avoided the bug by forcing preprocessing for your preview page, even though it has never contained any preprocessing...
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #629926 - Flags: review?(iann_bugzilla)
Attachment #629926 - Flags: feedback?(gavin.sharp)
Comment on attachment 629926 [details] [diff] [review]
Proposed patch

sure
Attachment #629926 - Flags: feedback?(gavin.sharp) → feedback+
Attached patch Firefox port (obsolete) — Splinter Review
Attachment #629989 - Flags: review?(gavin.sharp)
Attached patch Firefox portSplinter Review
Oops, forgot the about:feeds change
Attachment #629989 - Attachment is obsolete: true
Attachment #629989 - Flags: review?(gavin.sharp)
Attachment #629990 - Flags: review?(gavin.sharp)
Attachment #629926 - Flags: review?(iann_bugzilla) → review+
Attachment #629990 - Flags: review?(gavin.sharp) → review+
https://hg.mozilla.org/mozilla-central/rev/6a068ea39923
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.13
You need to log in before you can comment on or make changes to this bug.