761324 - [jsdbg2] Can we delete JSScript::debugMode?

Status: RESOLVED WONTFIX

(Core :: JavaScript Engine, defect)

Description

[Jim Blandy :jimb]

Could we delete JSScript::debugMode? Right now it's barely used at all:

- jsdbgapi's JS_SetFrameReturnValue uses it to assert.

- js_InternalInterpret's REJOIN_THIS_PROTOTYPE case uses it to decide whether to call js::ScriptDebugPrologue, but it seems like that might as well use f.cx->compartment->debugMode().

- js_PutCallObject uses it to decide whether to copy out args and vars from stack frame to call object en masse; it seems like something else could be used there, too.

Comment 1

[Luke Wagner [:luke]]

(In reply to Jim Blandy :jimb from comment #0)
> - js_PutCallObject uses it to decide whether to copy out args and vars from
> stack frame to call object en masse; it seems like something else could be
> used there, too.

*used*, as of b863ef9946b8 ;-)

Comment 2

[Nicholas Nethercote [inactive]]

Just beware that if you remove it, you'll probably have to tweak the padding to keep sizeof(JSScript) to a multiple of 8, including on --disable-methodjit builds.