Closed Bug 761331 Opened 12 years ago Closed 12 years ago

Remove our customized multipart_init() method

Categories

(Bugzilla :: Bugzilla-General, enhancement)

4.3.1
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 4.4

People

(Reporter: LpSolit, Assigned: LpSolit)

Details

Attachments

(1 file)

AFAIK, we no longer need our customized Bugzilla::CGI::multipart_init() method. The only reasons we had it was to set -nph to 0 instead of 1, which CGI.pm does since 3.05, and to set $CGI::HEADERS_ONCE = 0, which we no longer use. As Bugzilla 3.2 and newer require CGI.pm 3.51, we are no longer affected by the -nph problem and so this method can go away.
Attached patch patch, v1Splinter Review
I will let glob test this with mod_perl, as I have no such installation to play with.
Attachment #629933 - Flags: review?(glob)
Comment on attachment 629933 [details] [diff] [review]
patch, v1

r=glob works with mod_cgi and mod_perl
Attachment #629933 - Flags: review?(glob) → review+
Flags: approval?
Thanks! :)
Flags: approval? → approval+
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/CGI.pm
Committed revision 8255.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: