76139 - Over 900 successive lookups for the _same_ (frame, property)

Status: RESOLVED WORKSFORME

(Core :: Layout, defect)

Description

[rbs]

[spin off from bug 74656 - See Comments From Mike Shaver 2001-04-07 20:53] 

An incidental radar from shaver has found that the frame manager only end ups
storing a few dozen properties. However, the same (frame, property) pair
can sometimes be repeatedly requested over 900 times in succession.

Such a large loop is perhaps hiding another bigger fish. Indeed this incidental
finding may perhaps led to a hotspot in the application, the improvement of
which could be helpful performance-wise. Or it may perhaps show that the
property is always needed and is used extensively, to the point that it might be
simpler for it to be cached in the frame under consideration so as to avoid the
overhead of the trip to the frame manager.

I am entering this bug for the record, and cc:ing all those listed in bug 74656.

Comment 1

[James Green]

perf keyword, and nominating for 0.9.1 work.

Comment 2

[Keyser Sose]

Removing keyword...long gone.

Comment 3

[Mike Shaver (:shaver emeritus)]

I bet dbaron wants this.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Didn't someone already optimize successive lookups for the same property or
something?  (And was it the view property that was being looked up repeatedly in
this case?)

Comment 5

[Markus Hübner]

What's the current status of this one?

Comment 6

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Moving open bugs with topperf keyword to triage queue so they can be reassessed for performance priority.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Frame manager doesn't do hash lookups anymore.