761452 - Allow constructing/initializing a nsDependentJSString from a JSFlatString

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jeff Walden [:Waldo]]

Attachment: Patch

nsDependentJSString can be infallibly initialized from a jsid, or fallibly initialized from a JSString* or jsval.  But there's a separate kind of string, JSFlatString*, which could also be used to infallibly initialize an nsDependentJSString.  We should have a constructor and infallible init method that take such a value.  (I plan to use this in a patch for bug 758912.)

Comment 1

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 630002 [details] [diff] [review]
Patch

Is the JS_FORGET_STRING_FLATNESS ugliness really needed?  :(

r=me, I guess.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 630002 [details] [diff] [review]
Patch

Review of attachment 630002 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsJSUtils.h
@@ +102,5 @@
>  
> +  void init(JSFlatString* fstr)
> +  {
> +      new(this) nsDependentJSString(fstr);
> +  }

Assert IsEmpty(), please

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/aeceaac9445b