761454 - set MOZ_PKG_SPECIAL for armv6 mozconfigs to distinguish them from armv7 android builds

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(not currently active) Ted Mielczarek]

Currently if we start producing armv6 android builds the package name comes out the same as our existing builds. We should tack the MOZ_ARCH value onto the package name, but only if it's explicitly specified.

Comment 1

[(not currently active) Ted Mielczarek]

Attachment: package name should include MOZ_ARCH value if it's explicitly specified

I don't actually have my Android build environment here, but I configured a Mac build --with-arch=core2 and verified that $(PACKAGE) comes out as expected.

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 632765 [details] [diff] [review]
package name should include MOZ_ARCH value if it's explicitly specified

Review of attachment 632765 [details] [diff] [review]:
-----------------------------------------------------------------

I think I would be more comfortable with a completely separate variable. I don't think we need a complete configure option, but just AC_SUBSTing a variable that we'd export from mozconfig. The reason is that there is more than --with-arch that may change. As a matter of fact, we could also do armv7+neon builds, for example, which wouldn't even change --with-arch.

Comment 3

[(not currently active) Ted Mielczarek]

In that case, we can just use the already-existing MOZ_PKG_SPECIAL here, since that already works in mozconfigs:
http://mxr.mozilla.org/mozilla-central/source/browser/config/mozconfigs/macosx-universal/shark#22

Comment 4

[(not currently active) Ted Mielczarek]

Attachment: distinguish armv6 builds from armv7 builds by changing package name

Simple, should work fine.

Comment 5

[(not currently active) Ted Mielczarek]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f1a89d9008c8

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/f1a89d9008c8

Comment 7

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 633991 [details] [diff] [review]
distinguish armv6 builds from armv7 builds by changing package name

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: can't ship ARMv6 along side ARMv7
Testing completed (on m-c, etc.): landed on m-c when it was Fx16
Risk to taking this patch (and alternatives if risky): 
String or UUID changes made by this patch:

Comment 8

[(not currently active) Ted Mielczarek]

This patch has zero risk to shipping builds. It only impacts the armv6 build configuration, which is only being built on trunk.

Comment 9

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 633991 [details] [diff] [review]
distinguish armv6 builds from armv7 builds by changing package name

build config only change, approving.